Skip to content

Conversation

@mairaw
Copy link
Contributor

@mairaw mairaw commented Apr 3, 2018

Using the same file used in dotnet/docs

@mairaw mairaw added the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Apr 4, 2018
@mairaw mairaw added this to the Sprint 133 (3/17/18 - 4/06/18) milestone Apr 4, 2018
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, @mairaw. I did leave two comments about APIs that may not need to be included.

fullName: XDocument.ToString
fullName.vb: XDocument.ToString
- uid: System​.Runtime​.CompilerServices.IndexerNameAttribute
- uid: System.Runtime.CompilerServices.IndexerNameAttribute

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be here? IndexerNameAttribute is present in API Browser

name.vb: InAttribute
fullName: System.Runtime.InteropServices.InAttribute
fullName.vb: System.Runtime.InteropServices.InAttribute
- uid: System.Runtime.InteropServices.ComImportAttribute

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ComImportAttribute is also present in API Browser

@rpetrusha rpetrusha removed the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Apr 10, 2018
@mairaw
Copy link
Contributor Author

mairaw commented Apr 10, 2018

When I tried to find them last week, they seemed to not be there. I'll remove them.

@mairaw mairaw merged commit defa96f into master Apr 10, 2018
@mairaw mairaw deleted the mairaw-patch-2 branch April 10, 2018 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants