Skip to content

Restored enumeration member remarks #4 #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 14, 2019
Merged

Restored enumeration member remarks #4 #1842

merged 3 commits into from
Feb 14, 2019

Conversation

rpetrusha
Copy link

Restored enumeration member remarks #4

Contributes to #1306

@rpetrusha rpetrusha added the migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN label Feb 13, 2019
@rpetrusha rpetrusha added this to the February 2019 milestone Feb 13, 2019
@rpetrusha rpetrusha self-assigned this Feb 13, 2019
BillWagner
BillWagner approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @rpetrusha

You can :shipit: when ready.

mairaw
mairaw reviewed Feb 13, 2019
View reviewed changes
mairaw
mairaw reviewed Feb 13, 2019
View reviewed changes
mairaw
mairaw reviewed Feb 13, 2019
View reviewed changes
mairaw
mairaw reviewed Feb 13, 2019
View reviewed changes
mairaw
mairaw approved these changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but left a few comments to be addressed before merging (my comments should also probably fix the build warnings)

mairaw
mairaw reviewed Feb 13, 2019
View reviewed changes
mairaw
mairaw reviewed Feb 13, 2019
View reviewed changes
@mairaw
Apply suggestions from code review
f7b4f54 
Accepted reviewer suggestions. Thanks, @mairaw.

Co-Authored-By: rpetrusha <[email protected]>
@rpetrusha rpetrusha merged commit 9338297 into dotnet:master Feb 14, 2019
@rpetrusha rpetrusha deleted the enum-members-4 branch February 22, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

@BillWagner BillWagner BillWagner approved these changes

Assignees

@rpetrusha rpetrusha

Labels
migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN
Projects
None yet
Milestone
February 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@rpetrusha @BillWagner @mairaw