chore: polishing. put basic usage info to stdout using one call to a void messing lines #5019
Conversation
…oid messing lines
src/server/dfly_main.cc
Outdated
| for (const auto& dir : google::GetLoggingDirectories()) { | ||
| const string_view maybe_slash = absl::EndsWith(dir, "/") ? "" : "/"; | ||
| std::cout << dir << maybe_slash << "dragonfly.*\n"; | ||
| output += std::string(dir) + std::string(maybe_slash) + "dragonfly.*\n"; |
| std::cout << " @@ \n"; | ||
| std::cout << " .. \n"; | ||
| std::cout << "* Logs will be written to the first available of the following paths:\n"; | ||
| std::string output = |
There was a problem hiding this comment.
It changes below.
There was a problem hiding this comment.
it's fine to use std::string. Who cares 🤷 Same for absl:: variants. Just commented them for completeness
src/server/dfly_main.cc
Outdated
| for (const auto& dir : google::GetLoggingDirectories()) { | ||
| const string_view maybe_slash = absl::EndsWith(dir, "/") ? "" : "/"; | ||
| std::cout << dir << maybe_slash << "dragonfly.*\n"; | ||
| output += std::string(dir) + std::string(maybe_slash) + "dragonfly.*\n"; |
There was a problem hiding this comment.
There is also absl::StrCat or absl::StrAppend
| "* For the available flags type dragonfly [--help | --helpfull]\n" | ||
| "* Documentation can be found at: https://www.dragonflydb.io/docs\n"; | ||
|
|
||
| std::cout << output; |
There was a problem hiding this comment.
| std::cout << output; | |
| std::cout << output << std::endl; |
There was a problem hiding this comment.
better flush the output buffer
There was a problem hiding this comment.
I want to avoid more than one <<. This is the main idea of this change.
There was a problem hiding this comment.
But if you don't flush the internal io buffer, how do you know it gets printed ? cout uses buffered io so unless you flush with std::endl you don't know if it actually reached the output/terminal
There was a problem hiding this comment.
I added explicit flush. It solves the instant write. But the main idea was to avoid breaking lines and messing them up.
|
Can you plz elaborate:
|
I updated the description with the provided example. |
Sometimes we can see the lines being messed with at the start. This change fixes that.
The example from Grafana log:
