Skip to content

Fix parent_id was missed when logging under leaf span #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2022
Merged

Fix parent_id was missed when logging under leaf span #1695

merged 2 commits into from
Nov 16, 2022

Conversation

kalemas
Copy link
Contributor

@kalemas kalemas commented Nov 15, 2022

Related issues

Closes #1694

@cla-checker-service
Copy link

cla-checker-service bot commented Nov 15, 2022 •
edited
Loading

💚 CLA has been signed

@github-actions github-actions bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Nov 15, 2022
@ghost
Copy link

ghost commented Nov 15, 2022 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-16T18:35:44.811+0000

  • Duration: 19 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 5075
Skipped 3470
Total 8545

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kalemas kalemas mentioned this pull request Nov 15, 2022
Closed
@basepi
Copy link
Contributor

basepi commented Nov 16, 2022

/test

@ghost
Copy link

ghost commented Nov 16, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (68/68) 💚
Files 100.0% (230/230) 💚
Classes 100.0% (230/230) 💚
Lines 92.188% (18457/20021) 👎 -0.004
Conditionals 75.231% (2855/3795) 👎 -0.013

basepi
basepi approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@basepi basepi enabled auto-merge (squash) November 16, 2022 18:36
@basepi basepi merged commit 2e3ad36 into elastic:main Nov 16, 2022
@kalemas
Copy link
Contributor Author

kalemas commented Nov 19, 2022

I think it have to be revised over code code base, but there is few i can help. Thanks for quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basepi basepi basepi approved these changes

Assignees
No one assigned
Labels
agent-python community Issues opened by the community triage Issues awaiting triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning when capture_message in leaf span
2 participants
@kalemas @basepi