Skip to content

Assert no errors are in pipeline tests #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 15, 2021
Merged

Assert no errors are in pipeline tests #290

merged 3 commits into from
Mar 15, 2021

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Mar 15, 2021 •
edited
Loading

Issue: #281

@mtojek mtojek self-assigned this Mar 15, 2021
@mtojek mtojek requested a review from ycombinator March 15, 2021 10:30
@mtojek
Copy link
Contributor Author

mtojek commented Mar 15, 2021

/test

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 15, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: mtojek commented: /test

  • Start Time: 2021-03-15T15:34:58.560+0000

  • Duration: 19 min 32 sec

  • Commit: 760a83d

Test stats 🧪

Test Results
Failed 0
Passed 315
Skipped 1
Total 316

Trends 🧪

Image of Build Times

Image of Tests

ycombinator
ycombinator reviewed Mar 15, 2021
View reviewed changes
internal/testrunner/runners/pipeline/runner.go
@@ -311,6 +311,11 @@ func verifyDynamicFields(result *testResult, config *testConfig) error {
func verifyFieldsInTestResult(result *testResult, fieldsValidator *fields.Validator) error {
var multiErr multierror.Error
for _, event := range result.events {
err := checkErrorMessage(event)
if err != nil {
multiErr = append(multiErr, err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we continue here? IOW, should we check fields in the event if we find the error.message field?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... maybe you're right. Actually all other fields can be wrong, e.g. should be removed but weren't due to an error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@mtojek mtojek requested a review from ycombinator March 15, 2021 14:49
ycombinator
ycombinator approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mtojek
Copy link
Contributor Author

mtojek commented Mar 15, 2021

/test

@mtojek mtojek merged commit d74415f into elastic:master Mar 15, 2021
@mtojek mtojek mentioned this pull request Mar 15, 2021
Merged
@P1llus P1llus mentioned this pull request Apr 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtojek @elasticmachine @ycombinator