[STORE] [MODEL] Address performance of HashWrapper in Response objects #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7aaec34 to
8f76954
Compare
estolfo
added a commit
that referenced
this pull request
Sep 5, 2018
#825) * [STORE] Lazily wrap response in HashWrapper and provide #raw_response access * [MODEL] Lazily wrap response in HashWrapper and provide #raw_response access * [MODEL] Opimitize response changes * [STORE] Opimitize response changes
benjaminbarbe
pushed a commit
to beingenious/elasticsearch-rails
that referenced
this pull request
May 22, 2019
elastic#825) * [STORE] Lazily wrap response in HashWrapper and provide #raw_response access * [MODEL] Lazily wrap response in HashWrapper and provide #raw_response access * [MODEL] Opimitize response changes * [STORE] Opimitize response changes # Conflicts: # elasticsearch-persistence/lib/elasticsearch/persistence/repository/response/results.rb # elasticsearch-persistence/spec/repository/response/results_spec.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request intends to address the performance issues caused by request responses being wrapped in a
HashWrapper.The associated issue and pull request are:
The changes in this pull request, provide a
#raw_responsemethod on the response, if users want to avoid creating a HashWrapper for the response results. It also only creates the HashWrapper when the response is accessed, not upon instantiation of theRepository::Response::Resultsobject.