-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Add version prefix to Inference Service API path #117095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @demjened, I've created a changelog YAML for you. |
Pinging @elastic/search-inference-team (Team:Search - Inference) |
Pinging @elastic/search-eng (Team:SearchOrg) |
maxjakob
approved these changes
Nov 21, 2024
This was referenced Nov 22, 2024
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
* Add version prefix to EIS API path * Update docs/changelog/117095.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>enhancement
:SearchOrg/Inference
Label for the Search Inference team
Team:Search - Inference
Team:SearchOrg
Meta label for the Search Org (Enterprise Search)
v8.16.0
v8.16.1
v8.16.2
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the configuration of the Elastic Inference Service's inference API path. It adds the
/api/v1
prefix to the path, i.e.<EIS base URL>/api/v1/sparse-text-embedding/ELSERv2
.Currently EIS exposes both the versioned and unversioned endpoint with identical behavior. Once this PR is merged, the unversioned endpoint can be removed as there is no other dependency on it.