Skip to content

Add version prefix to Inference Service API path #117095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

demjened
Copy link
Contributor

@demjened demjened commented Nov 19, 2024

This PR updates the configuration of the Elastic Inference Service's inference API path. It adds the /api/v1 prefix to the path, i.e. <EIS base URL>/api/v1/sparse-text-embedding/ELSERv2.

Currently EIS exposes both the versioned and unversioned endpoint with identical behavior. Once this PR is merged, the unversioned endpoint can be removed as there is no other dependency on it.

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label and removed Team:Search - Inference labels Nov 20, 2024
@demjened demjened added the Team:SearchOrg Meta label for the Search Org (Enterprise Search) label Nov 20, 2024
@elasticsearchmachine elasticsearchmachine removed the Team:SearchOrg Meta label for the Search Org (Enterprise Search) label Nov 20, 2024
@demjened demjened added Team:SearchOrg Meta label for the Search Org (Enterprise Search) :SearchOrg/Inference Label for the Search Inference team labels Nov 20, 2024
@elasticsearchmachine elasticsearchmachine added Team:Search - Inference and removed needs:triage Requires assignment of a team area label labels Nov 20, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @demjened, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-inference-team (Team:Search - Inference)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

@demjened demjened merged commit e7a2a20 into elastic:main Nov 21, 2024
16 checks passed
@demjened demjened deleted the eis-versioned-api branch November 22, 2024 17:04
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
* Add version prefix to EIS API path

* Update docs/changelog/117095.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants