Skip to content

CrossClusterIT testCancel failure #117750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

drempapis
Copy link
Contributor

This pr #110019 changed the PlainActionFuture class, resulting in an ExecutionException to be thrown instead of a RuntimeException, when the V result() is called.

I updated the test assertion and control

Closes #108061

@drempapis drempapis self-assigned this Nov 29, 2024
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.0.0 labels Nov 29, 2024
@drempapis drempapis added >bug auto-backport Automatically create backport pull requests when merged Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch :Search Foundations/Search Catch all for Search Foundations v8.18.0 and removed needs:triage Requires assignment of a team area label labels Nov 29, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@elasticsearchmachine
Copy link
Collaborator

Hi @drempapis, I've created a changelog YAML for you.

Copy link
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming CI is happy), thanks for fixing this Dimitrios

@drempapis drempapis merged commit 6417e09 into elastic:main Nov 29, 2024
16 checks passed
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

drempapis added a commit to drempapis/elasticsearch that referenced this pull request Nov 29, 2024
 Investigate and fix test failure
elasticsearchmachine pushed a commit that referenced this pull request Nov 30, 2024
craigtaverner pushed a commit to craigtaverner/elasticsearch that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >bug :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] CrossClusterIT testCancel failing
3 participants