-
Notifications
You must be signed in to change notification settings - Fork 25.2k
CrossClusterIT testCancel failure #117750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
drempapis
merged 5 commits into
elastic:main
from
drempapis:fix/CrossClusterIT_testCancel_failure
Nov 29, 2024
Merged
CrossClusterIT testCancel failure #117750
drempapis
merged 5 commits into
elastic:main
from
drempapis:fix/CrossClusterIT_testCancel_failure
Nov 29, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
Hi @drempapis, I've created a changelog YAML for you. |
andreidan
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (assuming CI is happy), thanks for fixing this Dimitrios
💚 Backport successful
|
drempapis
added a commit
to drempapis/elasticsearch
that referenced
this pull request
Nov 29, 2024
Investigate and fix test failure
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 30, 2024
craigtaverner
pushed a commit
to craigtaverner/elasticsearch
that referenced
this pull request
Dec 2, 2024
Investigate and fix test failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
>bug
:Search Foundations/Search
Catch all for Search Foundations
Team:Search Foundations
Meta label for the Search Foundations team in Elasticsearch
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr #110019 changed the
PlainActionFuture
class, resulting in anExecutionException
to be thrown instead of aRuntimeException
, when theV result()
is called.I updated the test assertion and control
Closes #108061