Skip to content

Move SlowLogFieldProvider instantiation to node construction #117949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 6, 2025

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Dec 4, 2024

SPI from plugins should be created at node startup. This commit moves creation of SlowLogFieldProvider into node construction and passes it in to IndicesService so that it is not recreated on each index creation.

relates #102103

SPI from plugins should be created at node startup. This commit moves
creation of SlowLogFieldProvider into node construction and passes it in
to IndicesService so that it is not recreated on each index creation.

relates elastic#102103
@rjernst rjernst added >bug :Core/Infra/Logging Log management and logging utilities v9.0.0 v8.18.0 labels Dec 4, 2024
@rjernst rjernst requested a review from a team as a code owner December 4, 2024 00:12
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Dec 4, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Hi @rjernst, I've created a changelog YAML for you.

Copy link
Contributor

@mosche mosche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@rjernst rjernst added the auto-backport Automatically create backport pull requests when merged label Jan 6, 2025
@rjernst rjernst merged commit c19ee30 into elastic:main Jan 6, 2025
16 checks passed
@rjernst rjernst deleted the node/slow_log_provider branch January 6, 2025 17:07
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

rjernst added a commit to rjernst/elasticsearch that referenced this pull request Jan 6, 2025
…#117949)

SPI from plugins should be created at node startup. This commit moves
creation of SlowLogFieldProvider into node construction and passes it in
to IndicesService so that it is not recreated on each index creation.

relates elastic#102103
elasticsearchmachine pushed a commit that referenced this pull request Jan 6, 2025
#119602)

SPI from plugins should be created at node startup. This commit moves
creation of SlowLogFieldProvider into node construction and passes it in
to IndicesService so that it is not recreated on each index creation.

relates #102103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >bug :Core/Infra/Logging Log management and logging utilities Team:Core/Infra Meta label for core/infra team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants