Skip to content

Include hidden indices in DeprecationInfoAction #118035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Dec 4, 2024

This fixes an issue where the deprecation API wouldn't include hidden indices by default.

Resolves #118020

@dakrone dakrone force-pushed the deprecation-api-handle-hidden-indices9 branch from a35481b to f12ac2c Compare December 6, 2024 02:02
@dakrone dakrone added >bug :Data Management/Indices APIs APIs to create and manage indices and templates v8.18.0 labels Dec 6, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @dakrone, I've created a changelog YAML for you.

@dakrone
Copy link
Member Author

dakrone commented Dec 6, 2024

@elasticmachine update branch

@dakrone dakrone marked this pull request as ready for review December 6, 2024 19:05
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Dec 6, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @dakrone, I've updated the changelog YAML for you.

@dakrone
Copy link
Member Author

dakrone commented Dec 6, 2024

I haven't been able to find out a good way to test this. In integration tests ES does everything it can not to allow a user to create an index with an explicit index.created.version. So I've manually tested that this fixes the issue, but I haven't figured out any way to write an integration test for it.

@dakrone dakrone closed this Dec 6, 2024
@dakrone dakrone reopened this Dec 6, 2024
@valeriy42
Copy link
Contributor

@dakrone , is there a way to move forward with this PR? It would help us to test the upgrade workflow end-to-end.

Copy link
Contributor

@mattc58 mattc58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@dakrone dakrone added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport Automatically create backport pull requests when merged labels Dec 12, 2024
@dakrone
Copy link
Member Author

dakrone commented Dec 12, 2024

@elasticmachine update branch

@elasticsearchmachine elasticsearchmachine merged commit c449da8 into elastic:main Dec 12, 2024
16 checks passed
@dakrone dakrone deleted the deprecation-api-handle-hidden-indices9 branch December 12, 2024 22:15
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Dec 12, 2024
This fixes an issue where the deprecation API wouldn't include hidden
indices by default.

Resolves elastic#118020
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

elasticsearchmachine pushed a commit that referenced this pull request Dec 12, 2024
This fixes an issue where the deprecation API wouldn't include hidden
indices by default.

Resolves #118020
maxhniebergall pushed a commit to maxhniebergall/elasticsearch that referenced this pull request Dec 16, 2024
…stic#118630)

This fixes an issue where the deprecation API wouldn't include hidden
indices by default.

Resolves elastic#118020
maxhniebergall pushed a commit to maxhniebergall/elasticsearch that referenced this pull request Dec 16, 2024
…stic#118630)

This fixes an issue where the deprecation API wouldn't include hidden
indices by default.

Resolves elastic#118020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >bug :Data Management/Indices APIs APIs to create and manage indices and templates Team:Data Management Meta label for data/management team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GET _migration/deprecations doesn't show deprecations for hidden indices
5 participants