Skip to content

Match dot prefix of migrated DS backing index with the source index #120042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lukewhiting
Copy link
Contributor

This PR changes the index naming scheme used in ReindexDataStreamIndexTransportAction to match the dot prefix status of newly migrated indices.

If the source index does not start with a . then neither will the destination however if the source index does start with a . then so will the migrated index. Examples:

Source Destination
my-index migrated-my-index
.my-index .migrated-my-index

Also adds additional tests for the change.

Fixes ES-10506

@lukewhiting lukewhiting added >bug :Data Management/Data streams Data streams and their lifecycles auto-backport Automatically create backport pull requests when merged v9.0.0 v8.18.0 labels Jan 13, 2025
@lukewhiting lukewhiting force-pushed the match-dot-profix-in-ds-migration branch from 8e7c64d to 18a6888 Compare January 13, 2025 11:24
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Jan 13, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @lukewhiting, I've created a changelog YAML for you.

Copy link
Contributor

@parkertimmins parkertimmins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukewhiting lukewhiting merged commit de0e7c9 into elastic:main Jan 13, 2025
16 checks passed
lukewhiting added a commit to lukewhiting/elasticsearch that referenced this pull request Jan 13, 2025
…lastic#120042)

* Match dot prefix of migrated index with the source index

* Update docs/changelog/120042.yaml
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

elasticsearchmachine pushed a commit that referenced this pull request Jan 13, 2025
…120042) (#120063)

* Match dot prefix of migrated index with the source index

* Update docs/changelog/120042.yaml
@lukewhiting lukewhiting deleted the match-dot-profix-in-ds-migration branch January 14, 2025 08:41
martijnvg pushed a commit to martijnvg/elasticsearch that referenced this pull request Jan 14, 2025
…lastic#120042)

* Match dot prefix of migrated index with the source index

* Update docs/changelog/120042.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >bug :Data Management/Data streams Data streams and their lifecycles Team:Data Management Meta label for data/management team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants