Optimize loading mappings when determining synthetic source usage and whether host.name can be sorted on #120055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xModeSettingsProvider Optimize mapping service usages in when determining synthetic source usage and assessing whether host.name field can be used for index sorting. This is done by excluding the part of the mapping we're not interested in.
|
Hi @martijnvg, I've created a changelog YAML for you. |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
kkrik-es
reviewed
Jan 14, 2025
| for (CompressedXContent mappingSource : combinedTemplateMappings) { | ||
| var ref = mappingSource.compressedReference(); | ||
| var map = XContentHelper.convertToMap(ref, true, XContentType.JSON, MAPPING_INCLUDES, Set.of()).v2(); | ||
| processedTemplateMappings.add(new CompressedXContent(map)); |
There was a problem hiding this comment.
This is fairly cryptic. Can you add a comment above explaining the difference between processedTemplateMappings and combinedTemplateMappings?
|
Do we have enough testing coverage in the provider to capture all the interesting use cases where templates contain the interesting settings and fields? |
97e4775 to
ace4d23
Compare
I think the unit test coverage in |
kkrik-es
approved these changes
Jan 15, 2025
…ettingsProvider_2
…name settings with various mappings
💚 Backport successful
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize mapping service usages in when determining synthetic source usage and assessing whether host.name field can be used for index sorting. This is done by excluding the part of the mapping we're not interested in.
This replaces #119935 and addresses the problem differently, by just loading the parts of the mapping
LogsdbIndexModeSettingsProvideris interested in and by this lowering the overhead of parsing/merging mappings that has been reported via #119552