Skip to content

Revert unwanted ES|QL lexer changes from PR #120354 #120538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

tteofili
Copy link
Contributor

For some reason, PR #120354 made some unwanted changes to the ES|QL lexer file, reverting them.

@tteofili tteofili self-assigned this Jan 21, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jan 21, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Hi @tteofili, I've created a changelog YAML for you.

@tteofili tteofili enabled auto-merge (squash) January 21, 2025 16:00
Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'd say this is not a bug yet as it was not experienced by customers - I'd remove the >bug and the changelog.yml, and set this as a >non-issue.

@tteofili tteofili merged commit 04b5b7a into elastic:main Jan 21, 2025
15 of 16 checks passed
tteofili added a commit to tteofili/elasticsearch that referenced this pull request Jan 27, 2025
…20538)

* Revert unwanted ES|QL lexer changes from PR elastic#120354

* Update docs/changelog/120538.yaml

(cherry picked from commit 04b5b7a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants