[ML] Migrate stream to core error parsing #120722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid trapping Throwable by rethrowing it on another thread, allowing us to reuse the `generateFailureXContent` for Exceptions and match the new 9.0 format.
|
Hi @prwhelan, I've created a changelog YAML for you. |
|
Pinging @elastic/ml-core (Team:ML) |
jonathan-buttner
approved these changes
Jan 23, 2025
| e = (Exception) t; | ||
| } else { | ||
| // if not exception, then error, and we should not let it escape. rethrow on another thread, and inform the user we're stopping. | ||
| ExceptionsHelper.maybeDieOnAnotherThread(t); |
There was a problem hiding this comment.
Just curious, do we need this because we're in a listener? Or why is it that we want to throw the error on a different thread?
There was a problem hiding this comment.
My thought process was to throw on another thread and forward the error to the user, though now that I think about it maybe we should invert that (throw on this thread and forward the error on another thread), but perhaps I'm over thinking it.
This is what we did for Bedrock here - #115868
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Jan 27, 2025
Avoid trapping Throwable by rethrowing it on another thread, allowing us to reuse the `generateFailureXContent` for Exceptions and match the new 9.0 format.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid trapping Throwable by rethrowing it on another thread, allowing us to reuse the
generateFailureXContentfor Exceptions and match the new 9.0 format.