Skip to content

[ML] Remove Elastic Inference Service feature flag and deprecated setting #120842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 28, 2025
Merged

[ML] Remove Elastic Inference Service feature flag and deprecated setting #120842

merged 6 commits into from
Jan 28, 2025

Conversation

demjened
Copy link
Contributor

@demjened demjened commented Jan 24, 2025 •
edited
Loading

Removing Elastic Inference Service (EIS) feature flag and deprecated URL setting in favor of an access control method inside EIS.

@demjened demjened added auto-backport Automatically create backport pull requests when merged :SearchOrg/Inference Label for the Search Inference team v9.0.0 v8.18.0 labels Jan 24, 2025
@demjened demjened force-pushed the demjened/remove-eis-feature-flag branch from 4775476 to b7b2a1f Compare January 27, 2025 21:47
@demjened demjened changed the title [DO NOT MERGE] Remove EIS feature flag Remove Elastic Inference Service feature flag and deprecated setting Jan 27, 2025
@demjened demjened changed the title Remove Elastic Inference Service feature flag and deprecated setting [DO NOT MERGE] Remove Elastic Inference Service feature flag and deprecated setting Jan 27, 2025
@demjened demjened marked this pull request as ready for review January 28, 2025 04:23
@elasticsearchmachine elasticsearchmachine added Team:SearchOrg Meta label for the Search Org (Enterprise Search) Team:Search - Inference labels Jan 28, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-inference-team (Team:Search - Inference)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

@demjened demjened marked this pull request as draft January 28, 2025 04:24
@jonathan-buttner jonathan-buttner mentioned this pull request Jan 28, 2025
Merged
@demjened demjened changed the title [DO NOT MERGE] Remove Elastic Inference Service feature flag and deprecated setting Remove Elastic Inference Service feature flag and deprecated setting Jan 28, 2025
@demjened demjened marked this pull request as ready for review January 28, 2025 14:08
@maxjakob
Copy link
Contributor

/cc @vidok We don't need to set the feature flag for ECH.

@demjened demjened force-pushed the demjened/remove-eis-feature-flag branch from 09cde0b to fa37a35 Compare January 28, 2025 15:03
@demjened demjened force-pushed the demjened/remove-eis-feature-flag branch from c3b6f91 to 289277f Compare January 28, 2025 15:17
@elasticsearchmachine
Copy link
Collaborator

Hi @demjened, I've created a changelog YAML for you.

@demjened demjened changed the title Remove Elastic Inference Service feature flag and deprecated setting [ML] Remove Elastic Inference Service feature flag and deprecated setting Jan 28, 2025
maxjakob
maxjakob reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@maxjakob maxjakob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there are still merge conflicts

@vidok
Copy link
Contributor

vidok commented Jan 28, 2025

/cc @vidok We don't need to set the feature flag for ECH.

We don't set them for hosted. All FFs are enabled for snapshots and always disabled for normal builds. So no actions are required from our side.

@demjened demjened merged commit 3df6e34 into elastic:main Jan 28, 2025
16 checks passed
@demjened demjened deleted the demjened/remove-eis-feature-flag branch January 28, 2025 18:54
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 120842

This was referenced Jan 28, 2025
Merged
Merged
@jonathan-buttner jonathan-buttner mentioned this pull request Jan 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-buttner jonathan-buttner jonathan-buttner left review comments

@vidok vidok vidok approved these changes

@maxjakob maxjakob maxjakob approved these changes

@brendan-jugan-elastic brendan-jugan-elastic brendan-jugan-elastic approved these changes

@timgrein timgrein Awaiting requested review from timgrein

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged backport pending >enhancement :SearchOrg/Inference Label for the Search Inference team Team:Search - Inference Team:SearchOrg Meta label for the Search Org (Enterprise Search) v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@demjened @elasticsearchmachine @maxjakob @vidok @jonathan-buttner @brendan-jugan-elastic