Skip to content

[Transform] Delete Alias Write Index #122074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 12, 2025
Merged

[Transform] Delete Alias Write Index #122074

merged 10 commits into from
Feb 12, 2025

Conversation

prwhelan
Copy link
Member

@prwhelan prwhelan commented Feb 7, 2025

When the Transform is configured to write to an alias, specifying DELETE _transform/<id>?delete_dest_index will follow the alias to the concrete destination index.

Fix #121913

When the Transform is configured to write to an alias, specifying
`DELETE _transform/<id>?delete_dest_index` will follow the alias
to the concrete destination index.

Fix elastic#121913
@prwhelan prwhelan added >bug :ml/Transform Transform Team:ML Meta label for the ML team auto-backport Automatically create backport pull requests when merged v9.0.0 v8.18.0 v8.18.1 v8.19.0 v9.1.0 labels Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Documentation preview:

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Warning

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

@elasticsearchmachine
Copy link
Collaborator

Hi @prwhelan, I've created a changelog YAML for you.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Warning

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Warning

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Warning

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

@prwhelan prwhelan marked this pull request as ready for review February 7, 2025 20:04
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Copy link
Contributor

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,6 @@
pr: 122074
summary: Delete Alias Write Index
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the summary explain what is the visible impact of this PR for the customer.
Maybe sth like "Fix Delete API with delete_dest_index parameter when the destination index alias is used"?

@prwhelan prwhelan enabled auto-merge (squash) February 12, 2025 14:01
Copy link
Contributor

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prwhelan prwhelan merged commit 99c5398 into elastic:main Feb 12, 2025
15 of 17 checks passed
prwhelan added a commit to prwhelan/elasticsearch that referenced this pull request Feb 12, 2025
When the Transform is configured to write to an alias, specifying
`DELETE _transform/<id>?delete_dest_index` will follow the alias
to the concrete destination index.

Fix elastic#121913

Co-authored-by: Przemysław Witek <[email protected]>
prwhelan added a commit to prwhelan/elasticsearch that referenced this pull request Feb 12, 2025
When the Transform is configured to write to an alias, specifying
`DELETE _transform/<id>?delete_dest_index` will follow the alias
to the concrete destination index.

Fix elastic#121913

Co-authored-by: Przemysław Witek <[email protected]>
prwhelan added a commit to prwhelan/elasticsearch that referenced this pull request Feb 12, 2025
When the Transform is configured to write to an alias, specifying
`DELETE _transform/<id>?delete_dest_index` will follow the alias
to the concrete destination index.

Fix elastic#121913

Co-authored-by: Przemysław Witek <[email protected]>
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.0
8.18
8.x

elasticsearchmachine pushed a commit that referenced this pull request Feb 12, 2025
When the Transform is configured to write to an alias, specifying
`DELETE _transform/<id>?delete_dest_index` will follow the alias
to the concrete destination index.

Fix #121913

Co-authored-by: Przemysław Witek <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Feb 12, 2025
* [Transform] Delete Alias Write Index (#122074)

When the Transform is configured to write to an alias, specifying
`DELETE _transform/<id>?delete_dest_index` will follow the alias
to the concrete destination index.

Fix #121913

Co-authored-by: Przemysław Witek <[email protected]>

* Update for 8.x api

---------

Co-authored-by: Przemysław Witek <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Feb 12, 2025
* [Transform] Delete Alias Write Index (#122074)

When the Transform is configured to write to an alias, specifying
`DELETE _transform/<id>?delete_dest_index` will follow the alias
to the concrete destination index.

Fix #121913

Co-authored-by: Przemysław Witek <[email protected]>

* Update for 8.x api

---------

Co-authored-by: Przemysław Witek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >bug :ml/Transform Transform Team:ML Meta label for the ML team v8.18.0 v8.18.1 v8.19.0 v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Transform] Delete API fails when destination index writes to alias
3 participants