Skip to content

Ensure removal of index blocks does not leave key with null value #122246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

lukewhiting
Copy link
Contributor

This PR fixes a bug where the copy index from source action would leave keys will null values in the index settings after overriding index read/write blocks.

This patch addresses that by ensuring such block settings are completely removed rather than just getting nulled.

Fixes ES-10801

@lukewhiting lukewhiting added >bug :Data Management/Data streams Data streams and their lifecycles auto-backport Automatically create backport pull requests when merged v9.0.0 v8.18.1 v8.19.0 v9.1.0 labels Feb 11, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Feb 11, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @lukewhiting, I've created a changelog YAML for you.

Copy link
Member

@masseyke masseyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukewhiting lukewhiting merged commit 3f021a1 into elastic:main Feb 11, 2025
17 checks passed
lukewhiting added a commit to lukewhiting/elasticsearch that referenced this pull request Feb 11, 2025
…astic#122246)

* ES-10801 Ensure removal of index blocks does not leave key with null value

* Update docs/changelog/122246.yaml
lukewhiting added a commit to lukewhiting/elasticsearch that referenced this pull request Feb 11, 2025
…astic#122246)

* ES-10801 Ensure removal of index blocks does not leave key with null value

* Update docs/changelog/122246.yaml
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.0
8.18
8.x

elasticsearchmachine pushed a commit that referenced this pull request Feb 11, 2025
…22246) (#122265)

* ES-10801 Ensure removal of index blocks does not leave key with null value

* Update docs/changelog/122246.yaml
elasticsearchmachine pushed a commit that referenced this pull request Feb 11, 2025
…22246) (#122266)

* ES-10801 Ensure removal of index blocks does not leave key with null value

* Update docs/changelog/122246.yaml
elasticsearchmachine pushed a commit that referenced this pull request Feb 11, 2025
…22246) (#122264)

* ES-10801 Ensure removal of index blocks does not leave key with null value

* Update docs/changelog/122246.yaml
@lukewhiting lukewhiting deleted the es-10801-index-block-removal branch February 12, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >bug :Data Management/Data streams Data streams and their lifecycles Team:Data Management Meta label for data/management team v8.18.1 v8.19.0 v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants