Aggs: Let terms run in global ords mode no match #124782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the `terms` agg to run with global ords if the top level query matches no docs *but* the agg is configured to collect buckets with 0 docs.
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @nik9000, I've created a changelog YAML for you. |
| if (valuesSource.hasOrdinals() == false) { | ||
| execution = ExecutionMode.MAP; | ||
| } | ||
| if (matchNoDocs(context, parent) && bucketCountThresholds.getMinDocCount() > 0) { |
There was a problem hiding this comment.
I wonder if this should not kick in if the user sends a hint. We can run this in Global Ordinals mode, even if it's expensive, and if the user is asking to do that, it might be for a good reason.
|
Thanks @not-napoleon ! |
This was referenced Mar 21, 2025
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Mar 21, 2025
Allows the `terms` agg to run with global ords if the top level query matches no docs *but* the agg is configured to collect buckets with 0 docs.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Mar 21, 2025
Allows the `terms` agg to run with global ords if the top level query matches no docs *but* the agg is configured to collect buckets with 0 docs.
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 21, 2025
Allows the `terms` agg to run with global ords if the top level query matches no docs *but* the agg is configured to collect buckets with 0 docs.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 21, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 21, 2025
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Allows the `terms` agg to run with global ords if the top level query matches no docs *but* the agg is configured to collect buckets with 0 docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the
termsagg to run with global ords if the top level query matches no docs but the agg is configured to collect buckets with 0 docs. Collecting buckets with 0 docs is much faster in global ords mode.