-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Ignore _JAVA_OPTIONS #124843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore _JAVA_OPTIONS #124843
Conversation
The JVM has a couple ways that Java options can be passed. In Elasticsearch we ignore these common patterns, instead using our own bespoke mechanisms for setting options (ES_JAVA_OPTS, etc). The primary reason for this is some systems like Ubuntu setting these options globally and then affecting Elasticsearch, often in ways that cause Elasticsearch to fail to start. This commit ignores _JAVA_OPTIONS, which is a little known environment variable that the JVM may pick up options from.
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Hi @rjernst, I've created a changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need the same in distribution/src/bin/elasticsearch-env.bat
too
Doh! I had done the change to the .bat but the wrong one (a build file) 🤦 . Pushed that as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine update branch |
@elasticmachine update branch |
The JVM has a couple ways that Java options can be passed. In Elasticsearch we ignore these common patterns, instead using our own bespoke mechanisms for setting options (ES_JAVA_OPTS, etc). The primary reason for this is some systems like Ubuntu setting these options globally and then affecting Elasticsearch, often in ways that cause Elasticsearch to fail to start. This commit ignores _JAVA_OPTIONS, which is a little known environment variable that the JVM may pick up options from.
The JVM has a couple ways that Java options can be passed. In Elasticsearch we ignore these common patterns, instead using our own bespoke mechanisms for setting options (ES_JAVA_OPTS, etc). The primary reason for this is some systems like Ubuntu setting these options globally and then affecting Elasticsearch, often in ways that cause Elasticsearch to fail to start. This commit ignores _JAVA_OPTIONS, which is a little known environment variable that the JVM may pick up options from.
The JVM has a couple ways that Java options can be passed. In Elasticsearch we ignore these common patterns, instead using our own bespoke mechanisms for setting options (ES_JAVA_OPTS, etc). The primary reason for this is some systems like Ubuntu setting these options globally and then affecting Elasticsearch, often in ways that cause Elasticsearch to fail to start. This commit ignores _JAVA_OPTIONS, which is a little known environment variable that the JVM may pick up options from.
The JVM has a couple ways that Java options can be passed. In Elasticsearch we ignore these common patterns, instead using our own bespoke mechanisms for setting options (ES_JAVA_OPTS, etc). The primary reason for this is some systems like Ubuntu setting these options globally and then affecting Elasticsearch, often in ways that cause Elasticsearch to fail to start. This commit ignores _JAVA_OPTIONS, which is a little known environment variable that the JVM may pick up options from.
The JVM has a couple ways that Java options can be passed. In Elasticsearch we ignore these common patterns, instead using our own bespoke mechanisms for setting options (ES_JAVA_OPTS, etc). The primary reason for this is some systems like Ubuntu setting these options globally and then affecting Elasticsearch, often in ways that cause Elasticsearch to fail to start. This commit ignores _JAVA_OPTIONS, which is a little known environment variable that the JVM may pick up options from.
The JVM has a couple ways that Java options can be passed. In Elasticsearch we ignore these common patterns, instead using our own bespoke mechanisms for setting options (ES_JAVA_OPTS, etc). The primary reason for this is some systems like Ubuntu setting these options globally and then affecting Elasticsearch, often in ways that cause Elasticsearch to fail to start. This commit ignores _JAVA_OPTIONS, which is a little known environment variable that the JVM may pick up options from. Co-authored-by: Elastic Machine <[email protected]>
The JVM has a couple ways that Java options can be passed. In Elasticsearch we ignore these common patterns, instead using our own bespoke mechanisms for setting options (ES_JAVA_OPTS, etc). The primary reason for this is some systems like Ubuntu setting these options globally and then affecting Elasticsearch, often in ways that cause Elasticsearch to fail to start.
This commit ignores _JAVA_OPTIONS, which is a little known environment variable that the JVM may pick up options from.