Minor-Fixes Support 7x segments as archive in 8x / 9x #125666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @drempapis, I've created a changelog YAML for you. |
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
javanna
approved these changes
Mar 27, 2025
| // This code has been introduced to process IndexInput created with Lucene86Codec+. This is not necessary | ||
| // in the read-only version for older formats. | ||
| // The pre-8.6 code does not read the following fields that its standard Lucene counterpart does. After experimenting with the | ||
| // code, we got to the assumption that these are the last fields being read, which are not needed in the metadata-only reader, and |
There was a problem hiding this comment.
replace assumption with conclusion? :)
| // as some bytes are available to read. | ||
| // | ||
| // The extra reads have been introduced to process IndexInput created with Lucene86Codec+, where a new BKD format has been | ||
| // introduced. It seems that we have stricter checks around the header and footer starting from the 86 formats hence we do need to |
💚 Backport successful
|
drempapis
added a commit
to drempapis/elasticsearch
that referenced
this pull request
Mar 27, 2025
Minor fixes to support 7x segments as archive in 8x / 9x
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Minor fixes to support 7x segments as archive in 8x / 9x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor post-merge fixes of this work #119503 (review)