Skip to content

Fix system data stream restore warning #125881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JVerwolf
Copy link
Contributor

This PR fixes a bug in the RestoreService whereby the validation logic for index templates didn't account for system datastreams.

@JVerwolf JVerwolf added >bug :Core/Infra/Core Core issues without another label :Data Management/Data streams Data streams and their lifecycles auto-backport Automatically create backport pull requests when merged v8.18.1 v8.19.0 v9.0.1 v9.1.0 labels Mar 28, 2025
@JVerwolf JVerwolf requested review from masseyke and a team March 28, 2025 17:49
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team Team:Data Management Meta label for data/management team labels Mar 28, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @JVerwolf, I've created a changelog YAML for you.

Copy link
Member

@masseyke masseyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JVerwolf JVerwolf added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 28, 2025
@JVerwolf JVerwolf enabled auto-merge (squash) March 28, 2025 19:11
@JVerwolf JVerwolf merged commit 848a678 into elastic:main Mar 28, 2025
16 of 17 checks passed
@JVerwolf JVerwolf deleted the bugfix/fix-system-datastream-restore-warning branch March 28, 2025 19:15
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.18 Commit could not be cherrypicked due to conflicts
8.x Commit could not be cherrypicked due to conflicts
9.0

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 125881

JVerwolf added a commit to JVerwolf/elasticsearch that referenced this pull request Mar 28, 2025
This PR fixes a bug in the RestoreService whereby the validation logic for index templates didn't account for system datastreams.
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
This PR fixes a bug in the RestoreService whereby the validation logic for index templates didn't account for system datastreams.
@JVerwolf
Copy link
Contributor Author

I removed the v8.18.1 v8.19.0 back-port labels, as these branches don't actually contain the buggy code.

elasticsearchmachine pushed a commit that referenced this pull request Mar 29, 2025
This PR fixes a bug in the RestoreService whereby the validation logic for index templates didn't account for system datastreams.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport pending >bug :Core/Infra/Core Core issues without another label :Data Management/Data streams Data streams and their lifecycles Team:Core/Infra Meta label for core/infra team Team:Data Management Meta label for data/management team v9.0.1 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants