Skip to content

[8.x] Add Bounded Window to Inference Models for Rescoring to Ensure Positive Score Range (#125694) #126149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

markjhoy
Copy link
Contributor

@markjhoy markjhoy commented Apr 2, 2025

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…ve Score Range (elastic#125694)

* apply bounded window inference model

* linting

* add unit tests

* [CI] Auto commit changes from spotless

* add additional tests

* remove unused constructor

---------

Co-authored-by: elasticsearchmachine <[email protected]>
(cherry picked from commit e77bf80)
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we want to backport this to 9.0 too?

@markjhoy
Copy link
Contributor Author

markjhoy commented Apr 2, 2025

LGTM, do we want to backport this to 9.0 too?

Good question @afoucret, @jimczi - any reservations backporting this to 9.0? We'll probably want to wait until the next patch version, IMO though.

@markjhoy markjhoy merged commit 515cec4 into elastic:8.x Apr 23, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants