Skip to content

[Entitlements] Add missing outbound_network entitlement to x-pack-core #126992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 18, 2025

Conversation

ldematte
Copy link
Contributor

@ldematte ldematte commented Apr 17, 2025

Add missing outbound_network entitlement to x-pack-core

Closes #127003

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Hi @ldematte, I've created a changelog YAML for you.

@@ -17,6 +17,8 @@ org.apache.httpcomponents.httpcore.nio:
org.apache.httpcomponents.httpasyncclient:
- manage_threads
unboundid.ldapsdk:
- set_https_connection_properties
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you determine this one was necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not, I erred on the safe side. I think this might be not needed, but as we have 0 test coverage (evidently) I have no way to tell.
Maybe I can add a comment along those lines, that if/when we will have better test coverage we can remove that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the comment seems like a good idea, though I suppose anyone looking for the origin of that line will land on this PR and see this very conversation.

@elasticsearchmachine
Copy link
Collaborator

Hi @ldematte, I've updated the changelog YAML for you.

@ldematte ldematte enabled auto-merge (squash) April 18, 2025 07:15
@ldematte ldematte merged commit b6c9584 into elastic:main Apr 18, 2025
16 of 17 checks passed
ldematte added a commit to ldematte/elasticsearch that referenced this pull request May 8, 2025
elasticsearchmachine pushed a commit that referenced this pull request May 8, 2025
ldematte added a commit to ldematte/elasticsearch that referenced this pull request May 8, 2025
ldematte added a commit to ldematte/elasticsearch that referenced this pull request May 8, 2025
elasticsearchmachine pushed a commit that referenced this pull request May 8, 2025
elasticsearchmachine pushed a commit that referenced this pull request May 8, 2025
@jsevidal13
Copy link

Hi, @ldematte!

Would it be possible to update the labels on this PR to replace v8.18.1 with v8.18.2, and v9.0.1 to v9.0.2?

According to this KB article:

Resolving AD Authentication Issues in Elasticsearch 8.18.0/8.18.1 or 9.0.0/9.0.1

the fix unfortunately did not make it into 8.18.1 and v9.0.1, but those who come across this PR may think it was fixed in those versions unless the labels are updated on this PR.

Is there also a way to confirm if the fix made it into 8.19.0, or might that label need to be updated as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Active Directory Authentication does not work with Entitlements
4 participants