-
Notifications
You must be signed in to change notification settings - Fork 25.3k
[Entitlements] Add missing outbound_network entitlement to x-pack-core #126992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Entitlements] Add missing outbound_network entitlement to x-pack-core #126992
Conversation
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Hi @ldematte, I've created a changelog YAML for you. |
@@ -17,6 +17,8 @@ org.apache.httpcomponents.httpcore.nio: | |||
org.apache.httpcomponents.httpasyncclient: | |||
- manage_threads | |||
unboundid.ldapsdk: | |||
- set_https_connection_properties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you determine this one was necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not, I erred on the safe side. I think this might be not needed, but as we have 0 test coverage (evidently) I have no way to tell.
Maybe I can add a comment along those lines, that if/when we will have better test coverage we can remove that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah the comment seems like a good idea, though I suppose anyone looking for the origin of that line will land on this PR and see this very conversation.
Hi @ldematte, I've updated the changelog YAML for you. |
…tte/elasticsearch into entitlements/fix-xpack-core-policy
Hi, @ldematte! Would it be possible to update the labels on this PR to replace According to this KB article: Resolving AD Authentication Issues in Elasticsearch 8.18.0/8.18.1 or 9.0.0/9.0.1 the fix unfortunately did not make it into Is there also a way to confirm if the fix made it into |
Add missing outbound_network entitlement to x-pack-core
Closes #127003