Skip to content

Fix: Add NamedWriteable for RuleQueryRankDoc #128153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kderusso
Copy link
Member

Resolves #126071

Adds a NamedWriteable entry for RuleQueryRankDoc.

This failure isn't reproduceable in main with the given test script, but still occurs in Serverless, with failures such as the following:

"failures": [
      {
        "shard": 0,
        "index": "index-002",
        "node": "NA_btEkhTxKytf_u2V8LRQ",
        "reason": {
          "type": "illegal_argument_exception",
          "reason": "Unknown NamedWriteable [org.elasticsearch.search.rank.RankDoc][query_rule_rank_doc]"
        }
      },
      {
        "shard": 2,
        "index": "index-001",
        "node": "NA_btEkhTxKytf_u2V8LRQ",
        "reason": {
          "type": "illegal_argument_exception",
          "reason": "Unknown NamedWriteable [org.elasticsearch.search.rank.RankDoc][query_rule_rank_doc]"
        }
      }
    ]

@kderusso kderusso added >bug auto-backport Automatically create backport pull requests when merged :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v8.19.0 v9.1.0 v8.18.2 v9.0.2 labels May 19, 2025
@kderusso kderusso requested a review from a team May 19, 2025 17:37
@elasticsearchmachine elasticsearchmachine added Team:SearchOrg Meta label for the Search Org (Enterprise Search) Team:Search - Relevance The Search organization Search Relevance team labels May 19, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

@elasticsearchmachine
Copy link
Collaborator

Hi @kderusso, I've created a changelog YAML for you.

Copy link
Contributor

@Mikep86 Mikep86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also backport to 8.17?

@kderusso kderusso merged commit b335c1a into elastic:main May 21, 2025
18 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.19 Commit could not be cherrypicked due to conflicts
8.17 Commit could not be cherrypicked due to conflicts
8.18 Commit could not be cherrypicked due to conflicts
9.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 128153

kderusso added a commit to kderusso/elasticsearch that referenced this pull request May 21, 2025
* Add NamedWriteable for QueryRule rank doc

* Update test

* Update docs/changelog/128153.yaml

* Add multi cluster test for query rules

* Commenting out code - explicitly trying to spur a test failure

* [CI] Auto commit changes from spotless

* Streamline test for multi cluster

* Revert changes to try to break test

* Fix compile error

---------

Co-authored-by: elasticsearchmachine <[email protected]>
(cherry picked from commit b335c1a)

# Conflicts:
#	x-pack/plugin/ent-search/src/yamlRestTest/resources/rest-api-spec/test/entsearch/rules/40_rule_query_search.yml
kderusso added a commit to kderusso/elasticsearch that referenced this pull request May 21, 2025
* Add NamedWriteable for QueryRule rank doc

* Update test

* Update docs/changelog/128153.yaml

* Add multi cluster test for query rules

* Commenting out code - explicitly trying to spur a test failure

* [CI] Auto commit changes from spotless

* Streamline test for multi cluster

* Revert changes to try to break test

* Fix compile error

---------

Co-authored-by: elasticsearchmachine <[email protected]>
(cherry picked from commit b335c1a)

# Conflicts:
#	x-pack/plugin/ent-search/src/yamlRestTest/resources/rest-api-spec/test/entsearch/rules/40_rule_query_search.yml
@kderusso
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
9.0
8.19
8.18
8.17

Questions ?

Please refer to the Backport tool documentation

kderusso added a commit to kderusso/elasticsearch that referenced this pull request May 21, 2025
* Add NamedWriteable for QueryRule rank doc

* Update test

* Update docs/changelog/128153.yaml

* Add multi cluster test for query rules

* Commenting out code - explicitly trying to spur a test failure

* [CI] Auto commit changes from spotless

* Streamline test for multi cluster

* Revert changes to try to break test

* Fix compile error

---------

Co-authored-by: elasticsearchmachine <[email protected]>
(cherry picked from commit b335c1a)

# Conflicts:
#	x-pack/plugin/ent-search/src/yamlRestTest/resources/rest-api-spec/test/entsearch/rules/40_rule_query_search.yml
kderusso added a commit to kderusso/elasticsearch that referenced this pull request May 21, 2025
* Add NamedWriteable for QueryRule rank doc

* Update test

* Update docs/changelog/128153.yaml

* Add multi cluster test for query rules

* Commenting out code - explicitly trying to spur a test failure

* [CI] Auto commit changes from spotless

* Streamline test for multi cluster

* Revert changes to try to break test

* Fix compile error

---------

Co-authored-by: elasticsearchmachine <[email protected]>
(cherry picked from commit b335c1a)

# Conflicts:
#	x-pack/plugin/ent-search/qa/rest/src/yamlRestTest/resources/rest-api-spec/test/entsearch/rules/40_rule_query_search.yml
elasticsearchmachine pushed a commit that referenced this pull request May 21, 2025
* Fix: Add NamedWriteable for RuleQueryRankDoc (#128153)

* Add NamedWriteable for QueryRule rank doc

* Update test

* Update docs/changelog/128153.yaml

* Add multi cluster test for query rules

* Commenting out code - explicitly trying to spur a test failure

* [CI] Auto commit changes from spotless

* Streamline test for multi cluster

* Revert changes to try to break test

* Fix compile error

---------

Co-authored-by: elasticsearchmachine <[email protected]>
(cherry picked from commit b335c1a)

# Conflicts:
#	x-pack/plugin/ent-search/src/yamlRestTest/resources/rest-api-spec/test/entsearch/rules/40_rule_query_search.yml

* Update 40_rule_query_search.yml

Remove test that can't run in < 9.1
kderusso added a commit that referenced this pull request May 21, 2025
* Add NamedWriteable for QueryRule rank doc

* Update test

* Update docs/changelog/128153.yaml

* Add multi cluster test for query rules

* Commenting out code - explicitly trying to spur a test failure

* [CI] Auto commit changes from spotless

* Streamline test for multi cluster

* Revert changes to try to break test

* Fix compile error

---------

Co-authored-by: elasticsearchmachine <[email protected]>
(cherry picked from commit b335c1a)

# Conflicts:
#	x-pack/plugin/ent-search/qa/rest/src/yamlRestTest/resources/rest-api-spec/test/entsearch/rules/40_rule_query_search.yml
kderusso added a commit that referenced this pull request May 21, 2025
* Add NamedWriteable for QueryRule rank doc

* Update test

* Update docs/changelog/128153.yaml

* Add multi cluster test for query rules

* Commenting out code - explicitly trying to spur a test failure

* [CI] Auto commit changes from spotless

* Streamline test for multi cluster

* Revert changes to try to break test

* Fix compile error

---------

Co-authored-by: elasticsearchmachine <[email protected]>
(cherry picked from commit b335c1a)

# Conflicts:
#	x-pack/plugin/ent-search/src/yamlRestTest/resources/rest-api-spec/test/entsearch/rules/40_rule_query_search.yml
kderusso added a commit that referenced this pull request May 21, 2025
* Add NamedWriteable for QueryRule rank doc

* Update test

* Update docs/changelog/128153.yaml

* Add multi cluster test for query rules

* Commenting out code - explicitly trying to spur a test failure

* [CI] Auto commit changes from spotless

* Streamline test for multi cluster

* Revert changes to try to break test

* Fix compile error

---------

Co-authored-by: elasticsearchmachine <[email protected]>
(cherry picked from commit b335c1a)

# Conflicts:
#	x-pack/plugin/ent-search/src/yamlRestTest/resources/rest-api-spec/test/entsearch/rules/40_rule_query_search.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged backport pending >bug :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Search - Relevance The Search organization Search Relevance team Team:SearchOrg Meta label for the Search Org (Enterprise Search) v8.17.7 v8.18.2 v8.19.0 v9.0.2 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rules Retriever Failing with Unknown NamedWriteable
3 participants