-
Notifications
You must be signed in to change notification settings - Fork 25.3k
[ES|QL] Substitue date_trunc with round_to when the pre-calculated rounding points are available #128639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
fang-xing-esql
wants to merge
13
commits into
elastic:main
Choose a base branch
from
fang-xing-esql:date-trunc-search-stats
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[ES|QL] Substitue date_trunc with round_to when the pre-calculated rounding points are available #128639
fang-xing-esql
wants to merge
13
commits into
elastic:main
from
fang-xing-esql:date-trunc-search-stats
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @fang-xing-esql, I've created a changelog YAML for you. |
…r multiple quantities for month/quarter/year
…r multiple quantities for month/quarter/year
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subtask of the filter-by-filter aggregation in
ES|QL
. And the following changes are included in this PR.SearchStats
, according to the statistics retrieved from Lucent forDateFieldType
only, addedSearchContextStatsTests
, and testedmin
/max
.SearchStats
, provide them toDateTrunc.createRounding
, callprepare(min, max)
, instead ofprepareForUnknown()
.fixedRoundingPoints()
, substitutedate_trunc
andbucket
withround_to
function. A new ruleSubstituteSurrogateExpressionsWithSearchStats
is added in the local rewrite batch inLocalLogicalPlanOptimizer
to do the substitution.date_trunc
/bucket
toround_to
does not apply todate_nanos
yet, as the underlying APIs support millis only, and nanos has not been tested yet.PreparedRounding.maybeUseArray
may hit an assert if the calendar intervals are multiple quantities, like 10 month or 3 quarter, date histogram aggregation has this limitation documented here,this is likely why the assert hasn't been hit before, and the same limitation will apply to this rewrite.Next step: performance validations.