Skip to content

Adjust default geoip logging to be less verbose. #81404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2021
Merged

Adjust default geoip logging to be less verbose. #81404

merged 1 commit into from
Dec 13, 2021

Conversation

martijnvg
Copy link
Member

Changes several logs from info level to debug level and
slightly changed some log messages.

Relates to #81356

@martijnvg
Adjust default geoip logging to be less verbose.
466e6ad 
Changes several logs from info level to debug level and
slightly changed some log messages.

Relates to elastic#81356
@martijnvg martijnvg added >bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v8.0.0 v8.1.0 labels Dec 7, 2021
@martijnvg martijnvg requested a review from probakowski December 7, 2021 06:05
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Dec 7, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@martijnvg
Copy link
Member Author

Without this change the geoip startup logging looks like:

[2021-12-07T07:18:39,151][INFO ][o.e.i.g.ConfigDatabases  ] [runTask-0] initialized config databases [[]] and watching [/Users/mvg/dev/code/elasticsearch/master/build/testclusters/runTask-0/config/ingest-geoip] for changes
[2021-12-07T07:18:39,153][INFO ][o.e.i.g.DatabaseNodeService] [runTask-0] initialized database registry, using geoip-databases directory [/Users/mvg/dev/code/elasticsearch/master/build/testclusters/runTask-0/tmp/geoip-databases/7BmZ2kPMTS2EkjZ7V14aZA]
[2021-12-07T07:18:51,923][INFO ][o.e.i.g.GeoIpDownloader  ] [runTask-0] updating geoip databases
[2021-12-07T07:18:51,924][INFO ][o.e.i.g.GeoIpDownloader  ] [runTask-0] fetching geoip databases overview from [https://geoip.elastic.co/v1/database?elastic_geoip_service_tos=agree]
[2021-12-07T07:18:52,515][INFO ][o.e.i.g.GeoIpDownloader  ] [runTask-0] updating geoip database [GeoLite2-ASN.mmdb]
[2021-12-07T07:18:54,407][INFO ][o.e.i.g.DatabaseNodeService] [runTask-0] downloading geoip database [GeoLite2-ASN.mmdb] to [/Users/mvg/dev/code/elasticsearch/master/build/testclusters/runTask-0/tmp/geoip-databases/7BmZ2kPMTS2EkjZ7V14aZA/GeoLite2-ASN.mmdb.tmp.gz]
[2021-12-07T07:18:54,410][INFO ][o.e.i.g.GeoIpDownloader  ] [runTask-0] updated geoip database [GeoLite2-ASN.mmdb]
[2021-12-07T07:18:54,426][INFO ][o.e.i.g.GeoIpDownloader  ] [runTask-0] updating geoip database [GeoLite2-City.mmdb]
[2021-12-07T07:18:54,585][INFO ][o.e.i.g.DatabaseNodeService] [runTask-0] successfully reloaded changed geoip database file [/Users/mvg/dev/code/elasticsearch/master/build/testclusters/runTask-0/tmp/geoip-databases/7BmZ2kPMTS2EkjZ7V14aZA/GeoLite2-ASN.mmdb]
[2021-12-07T07:18:58,391][INFO ][o.e.i.g.DatabaseNodeService] [runTask-0] downloading geoip database [GeoLite2-City.mmdb] to [/Users/mvg/dev/code/elasticsearch/master/build/testclusters/runTask-0/tmp/geoip-databases/7BmZ2kPMTS2EkjZ7V14aZA/GeoLite2-City.mmdb.tmp.gz]
[2021-12-07T07:18:58,393][INFO ][o.e.i.g.GeoIpDownloader  ] [runTask-0] updated geoip database [GeoLite2-City.mmdb]
[2021-12-07T07:18:58,395][INFO ][o.e.i.g.GeoIpDownloader  ] [runTask-0] updating geoip database [GeoLite2-Country.mmdb]
[2021-12-07T07:18:59,873][INFO ][o.e.i.g.DatabaseNodeService] [runTask-0] downloading geoip database [GeoLite2-Country.mmdb] to [/Users/mvg/dev/code/elasticsearch/master/build/testclusters/runTask-0/tmp/geoip-databases/7BmZ2kPMTS2EkjZ7V14aZA/GeoLite2-Country.mmdb.tmp.gz]
[2021-12-07T07:18:59,875][INFO ][o.e.i.g.GeoIpDownloader  ] [runTask-0] updated geoip database [GeoLite2-Country.mmdb]
[2021-12-07T07:18:59,949][INFO ][o.e.i.g.DatabaseNodeService] [runTask-0] successfully reloaded changed geoip database file [/Users/mvg/dev/code/elasticsearch/master/build/testclusters/runTask-0/tmp/geoip-databases/7BmZ2kPMTS2EkjZ7V14aZA/GeoLite2-Country.mmdb]
[2021-12-07T07:19:00,358][INFO ][o.e.i.g.DatabaseNodeService] [runTask-0] successfully reloaded changed geoip database file [/Users/mvg/dev/code/elasticsearch/master/build/testclusters/runTask-0/tmp/geoip-databases/7BmZ2kPMTS2EkjZ7V14aZA/GeoLite2-City.mmdb]

And with this change:

[2021-12-07T07:13:04,367][INFO ][o.e.i.g.GeoIpDownloader  ] [runTask-0] successfully downloaded geoip database [GeoLite2-ASN.mmdb]
[2021-12-07T07:13:04,540][INFO ][o.e.i.g.DatabaseNodeService] [runTask-0] successfully loaded geoip database file [GeoLite2-ASN.mmdb]
[2021-12-07T07:13:08,333][INFO ][o.e.i.g.GeoIpDownloader  ] [runTask-0] successfully downloaded geoip database [GeoLite2-City.mmdb]
[2021-12-07T07:13:09,895][INFO ][o.e.i.g.GeoIpDownloader  ] [runTask-0] successfully downloaded geoip database [GeoLite2-Country.mmdb]
[2021-12-07T07:13:09,977][INFO ][o.e.i.g.DatabaseNodeService] [runTask-0] successfully loaded geoip database file [GeoLite2-Country.mmdb]
[2021-12-07T07:13:10,306][INFO ][o.e.i.g.DatabaseNodeService] [runTask-0] successfully loaded geoip database file [GeoLite2-City.mmdb]

Note that this is from a single node cluster. Logs from GeoIpDownloader logs are only printed by default on the node that runs the geoip downloader task and logs from DatabaseNodeService are only printed on nodes with the ingest role.

probakowski
probakowski approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@probakowski probakowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @martijnvg

@martijnvg
Copy link
Member Author

Thanks @probakowski for reviewing!

@martijnvg martijnvg merged commit b2c0392 into elastic:master Dec 13, 2021
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 81404

martijnvg added a commit to martijnvg/elasticsearch that referenced this pull request Dec 13, 2021
@martijnvg
Adjust default geoip logging to be less verbose.
0be3383 
Backport elastic#81404 to 8.0 branch.

Changes several logs from info level to debug level and
slightly changed some log messages.

Relates to elastic#81356
@martijnvg martijnvg mentioned this pull request Dec 13, 2021
Merged
martijnvg added a commit that referenced this pull request Dec 13, 2021
@martijnvg
Adjust default geoip logging to be less verbose. (#81640)
6dd96d4 
Backport #81404 to 8.0 branch.

Changes several logs from info level to debug level and
slightly changed some log messages.

Relates to #81356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@probakowski probakowski probakowski approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
>bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team v8.0.0-rc2 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@martijnvg @elasticmachine @elasticsearchmachine @probakowski @pugnascotia