Skip to content

Using startsWith rather than exact matches for watcher history template names #82396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2022
Merged

Using startsWith rather than exact matches for watcher history template names #82396

merged 2 commits into from
Jan 13, 2022

Conversation

masseyke
Copy link
Member

This commit makes the check for watcher history template names a little more flexible, by checking for any with version
greater than or equal to 12, rather than listing out versions.

@masseyke masseyke requested a review from jakelandis January 11, 2022 00:13
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jan 11, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

jakelandis
jakelandis approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masseyke masseyke merged commit c310239 into elastic:master Jan 13, 2022
@masseyke masseyke deleted the feature/more-flexible-watcher-template-check branch January 13, 2022 19:06
masseyke added a commit to masseyke/elasticsearch that referenced this pull request Jan 13, 2022
@masseyke
Using startsWith rather than exact matches for watcher history templa…
eb7b587 
…te names (elastic#82396)

This commit makes the check for watcher history template names a little more flexible, by checking for
any with version greater than or equal to 12, rather than listing out versions.
elasticsearchmachine pushed a commit that referenced this pull request Jan 13, 2022
@masseyke
Using startsWith rather than exact matches for watcher history templa…
2b32a06 
…te names (#82396) (#82571)

This commit makes the check for watcher history template names a little more flexible, by checking for
any with version greater than or equal to 12, rather than listing out versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelandis jakelandis jakelandis approved these changes

Assignees
No one assigned
Labels
:Data Management/Watcher >feature Team:Data Management Meta label for data/management team v8.0.0-rc2 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@masseyke @elasticmachine @jakelandis @pugnascotia