Fix AdaptingAggregator toString method #86042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most aggregations inheriting from AggregatorBase implement 'toString()' by printing the name of the aggregation, but AdaptingAggregator and subclasses don't, so they will print Object#toString(). In some tests where we e.g. compare response json outputs for equality this can cause errors because two separate instances will have different string representations. This changes fixes that by also using the name of the aggregation here.
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
|
Hi @cbuescher, I've created a changelog YAML for you. |
|
See #85538 (comment) for an example how this can cause a problem in our tests. |
nik9000
approved these changes
Apr 20, 2022
|
@nik thanks for the review |
|
Hi @cbuescher, I've created a changelog YAML for you. |
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Apr 21, 2022
Most aggregations inheriting from AggregatorBase implement 'toString()' by printing the name of the aggregation, but AdaptingAggregator and subclasses don't, so they will print Object#toString(). In some tests where we e.g. compare response json outputs for equality this can cause errors because two separate instances will have different string representations. This changes fixes that by also using the name of the aggregation here.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 21, 2022
Most aggregations inheriting from AggregatorBase implement 'toString()' by printing the name of the aggregation, but AdaptingAggregator and subclasses don't, so they will print Object#toString(). In some tests where we e.g. compare response json outputs for equality this can cause errors because two separate instances will have different string representations. This changes fixes that by also using the name of the aggregation here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most aggregations inheriting from AggregatorBase implement 'toString()' by
printing the name of the aggregation, but AdaptingAggregator and subclasses
don't, so they will print Object#toString(). In some tests where we e.g. compare
response json outputs for equality this can cause errors because two separate
instances will have different string representations. This changes fixes that by
also using the name of the aggregation here.
Relates to #85538