Fix mvt polygon orientation #86555
Merged
Fix mvt polygon orientation #86555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
|
Hi @iverase, I've created a changelog YAML for you. |
|
Hi @iverase, I've updated the changelog YAML for you. |
craigtaverner
approved these changes
May 9, 2022
| // Check CCW Winding (must be positive area in original coordinate system, MVT is positive-y-down, | ||
| // so inequality is flipped) | ||
| // See: https://docs.mapbox.com/vector-tiles/specification/#winding-order | ||
| if (exteriorArea > 0d) { |
There was a problem hiding this comment.
I presume this is the change
There was a problem hiding this comment.
yes, that is the orientation for the outer ring
| // Check CW Winding (must be negative area in original coordinate system, MVT is positive-y-down, | ||
| // so inequality is flipped) | ||
| // See: https://docs.mapbox.com/vector-tiles/specification/#winding-order | ||
| if (interiorArea < 0d) { |
There was a problem hiding this comment.
yes, that is the orientation for inner rings (holes)
| assertThat(feature.getGeometryCount(), equalTo(22)); | ||
| { | ||
| // outer ring | ||
| double[] xs = new double[5]; |
There was a problem hiding this comment.
Understanding these tests requires inner knowledge of the MVT tile encoding, which I do not (yet) have.
…ch into fixMVTPolOrientation
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
May 17, 2022
This commit forks the method we use in JTSAdapter to generate the vector tile feature containing the right logic for polygon orientation.
💔 Backport failed
You can use sqren/backport to manually backport by running |
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
May 17, 2022
This commit forks the method we use in JTSAdapter to generate the vector tile feature containing the right logic for polygon orientation. # Conflicts: # x-pack/plugin/vector-tile/src/test/java/org/elasticsearch/xpack/vectortile/feature/FeatureFactoryTests.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 17, 2022
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 17, 2022
* Fix mvt polygon orientation (#86555) This commit forks the method we use in JTSAdapter to generate the vector tile feature containing the right logic for polygon orientation. # Conflicts: # x-pack/plugin/vector-tile/src/test/java/org/elasticsearch/xpack/vectortile/feature/FeatureFactoryTests.java * compile error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current library we use to encode mvt geometries into vector tiles features handle incorrectly the orientation of the polygons. The main branch of the project contains a fix to the issue but it has not been released.
This PR forks the method we use in JTSAdapter to generate the vector tile feature containing the fix for polygon orientation.
fixes #86560