-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Correctly calculate disk usage for frozen data tier telemetry #86580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
elasticsearchmachine
merged 3 commits into
elastic:master
from
dakrone:use-total-data-set-for-tier-telemetry
May 12, 2022
Merged
Correctly calculate disk usage for frozen data tier telemetry #86580
elasticsearchmachine
merged 3 commits into
elastic:master
from
dakrone:use-total-data-set-for-tier-telemetry
May 12, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The telemetry for data tiers was using the size in bytes, however, for the frozen tier using searchable snapshots, this was the disk usage rather than the size of the actual data. This commit changes the telemetry to use `total_data_set_size` as introduced in elastic#70625 so that the telemetry is correct. Resolves elastic#86055
Pinging @elastic/es-data-management (Team:Data Management) |
Hi @dakrone, I've created a changelog YAML for you. |
@elasticmachine run elasticsearch-ci/part-2 |
gmarouli
approved these changes
May 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
@elasticmachine update branch |
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
May 12, 2022
…c#86580) The telemetry for data tiers was using the size in bytes, however, for the frozen tier using searchable snapshots, this was the disk usage rather than the size of the actual data. This commit changes the telemetry to use `total_data_set_size` as introduced in elastic#70625 so that the telemetry is correct. Resolves elastic#86055
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
May 12, 2022
…c#86580) The telemetry for data tiers was using the size in bytes, however, for the frozen tier using searchable snapshots, this was the disk usage rather than the size of the actual data. This commit changes the telemetry to use `total_data_set_size` as introduced in elastic#70625 so that the telemetry is correct. Resolves elastic#86055
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 12, 2022
#86749) The telemetry for data tiers was using the size in bytes, however, for the frozen tier using searchable snapshots, this was the disk usage rather than the size of the actual data. This commit changes the telemetry to use `total_data_set_size` as introduced in #70625 so that the telemetry is correct. Resolves #86055
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 12, 2022
#86748) The telemetry for data tiers was using the size in bytes, however, for the frozen tier using searchable snapshots, this was the disk usage rather than the size of the actual data. This commit changes the telemetry to use `total_data_set_size` as introduced in #70625 so that the telemetry is correct. Resolves #86055
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
>bug
:Data Management/Stats
Statistics tracking and retrieval APIs
Team:Data Management
Meta label for data/management team
v7.17.4
v8.2.1
v8.3.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The telemetry for data tiers was using the size in bytes, however, for the frozen tier using
searchable snapshots, this was the disk usage rather than the size of the actual data.
This commit changes the telemetry to use
total_data_set_size
as introduced in #70625 so that thetelemetry is correct.
Resolves #86055