aws: improve error.message and add event.kind:pipeline_error for pipeline errors #11112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
guardduty |
1152.07 | 801.28 | -350.79 (-30.45%) | 💔 |
waf |
7407.41 | 5917.16 | -1490.25 (-20.12%) | 💔 |
cloudfront_logs |
2518.89 | 1923.08 | -595.81 (-23.65%) | 💔 |
cloudwatch_logs |
500000 | 250000 | -250000 (-50%) | 💔 |
elb_logs |
4739.34 | 3937.01 | -802.33 (-16.93%) | 💔 |
firewall_logs |
3184.71 | 2538.07 | -646.64 (-20.3%) | 💔 |
To see the full report comment with /test benchmark fullreport
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
kcreddy
approved these changes
Sep 13, 2024
4 tasks
ishleenk17
approved these changes
Oct 8, 2024
andrewkroh
approved these changes
Oct 8, 2024
| value: pipeline_error | ||
| - append: | ||
| field: error.message | ||
| value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.on_failure_pipeline}}} failed with message: {{{_ingest.on_failure_message}}}' |
There was a problem hiding this comment.
If you have an easy way to update these, consider making the "with tag" part conditional on whether the processor has a tag.
For example:
|
@romulets I would like to understand how to resolve the conflicts in this PR. There are three possible approaches (four):
|
agithomas
reviewed
Oct 9, 2024
| value: "{{ _ingest.on_failure_message }}" | ||
| value: >- | ||
| Processor '{{{ _ingest.on_failure_processor_type }}}' | ||
| {{{#_ingest.on_failure_processor_tag}}}with tag '{{{ _ingest.on_failure_processor_tag }}}' |
There was a problem hiding this comment.
nit:
For a few values, with tag (whitespace in front of with) is used, for a few this whitespace is missing.
There was a problem hiding this comment.
Thanks, I thought I got all of them with a s///g.
5 tasks
kruskall
approved these changes
Oct 14, 2024
constanca-m
approved these changes
Oct 14, 2024
|
@ishleenk17 and @constanca-m it would be really helpful if you could also check out the blocking PR #11397 that this depends on. |
kaiyan-sheng
approved these changes
Oct 14, 2024
…line errors Also fix instances of incorrect yaml for script processors.
|
💚 Build Succeeded
History
cc @efd6 |
|
Package aws - 2.27.0 containing this change is available at https://epr.elastic.co/search?package=aws |
harnish-elastic
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
…line errors (elastic#11112) Also fix instances of incorrect yaml for script processors.
harnish-elastic
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
…line errors (elastic#11112) Also fix instances of incorrect yaml for script processors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Also fix instances of incorrect yaml for script processors.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
related.entity(and add missing data) #11397Screenshots