Fix bug in Third Party REST API ingest pipeline #1201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
2a8af38 to
2d1dcf5
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
P1llus
approved these changes
Jun 28, 2021
| target_field: '_id' | ||
| ignore_missing: true | ||
| - set: | ||
| field: event.original |
There was a problem hiding this comment.
Just a general question, I am quite sure that set always correctly overwrites fields right? Since event.original is already set at this point?
There was a problem hiding this comment.
Correct, set overwrites any previous value
marc-gr
approved these changes
Jun 28, 2021
- Apache - Zeek - Nginx - CloudTrail - move third party api processing to separate pipeline - convert rename to set so value can be overwritten Fixes elastic#1146
2d1dcf5 to
b05f9c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes bug in Third Party REST API ingest pipelines where a rename of
host.name would fail because it was already set. Also moves third
party api processing to a separate pipeline.
Checklist
changelog.ymlfile.- [ ] If I'm introducing a new feature, I have modified the Kibana version constraint in my package'smanifest.ymlfile to point to the latest Elastic stack release (e.g.^7.13.0).How to test this PR locally
need to install Splunk & ingest data into that, then configure these
integrations. Bug isn't visible with pipeline tests.
Related issues