-
Notifications
You must be signed in to change notification settings - Fork 462
auditd: changes for unified integration UI #2002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/integrations (Team:Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
@jamiehynds I prepared this PR but this package is owned by Security Integrations. May I get a 👍 from you too before merging? |
LGTM |
packages/auditd/manifest.yml
Outdated
@@ -14,7 +14,7 @@ license: basic | |||
categories: | |||
- os_system | |||
conditions: | |||
kibana.version: ^7.14.0 | |||
kibana.version: "^7.16.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should bump the required Kibana version given that it's only changing the description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @andrewkroh - sorry, I just looked at the updated description and missed the version bump.
packages/auditd/manifest.yml
Outdated
@@ -1,8 +1,8 @@ | |||
name: auditd | |||
title: Auditd | |||
version: 1.2.3 | |||
version: 1.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version: 1.3.0 | |
version: 1.2.4 |
How about a patch version bump given this is really minimal and introduces no new features.
I removed the version constraint update and bumped patch instead of minor. Lets see if CI is happy today. |
What does this PR do?
Align package title and description for improved Unified Integration UI display.
Checklist
I have reviewed tips for building integrations and this pull request is aligned with them.I have verified that all data streams collect metrics or logs.changelog.yml
file.manifest.yml
file to point to the latest Elastic stack release (e.g.^7.13.0
).Author's Checklist
How to test this PR locally
Related issues
Screenshots