Skip to content

auditd: changes for unified integration UI #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2021
Merged

auditd: changes for unified integration UI #2002

merged 3 commits into from
Oct 27, 2021

Conversation

endorama
Copy link
Member

What does this PR do?

Align package title and description for improved Unified Integration UI display.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

  • promote package to staging
  • promote package to production

How to test this PR locally

Related issues

Screenshots

@endorama endorama added the Team:Integrations Label for the Integrations team label Oct 21, 2021
@endorama endorama self-assigned this Oct 21, 2021
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@endorama endorama changed the title activemq: changes for unified integration UI auditd: changes for unified integration UI Oct 21, 2021
@elasticmachine
Copy link

elasticmachine commented Oct 21, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-25T08:27:29.836+0000

  • Duration: 14 min 33 sec

  • Commit: 824ad74

Test stats 🧪

Test Results
Failed 0
Passed 13
Skipped 0
Total 13

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@endorama
Copy link
Member Author

@jamiehynds I prepared this PR but this package is owned by Security Integrations. May I get a 👍 from you too before merging?

@jamiehynds
Copy link

LGTM

@@ -14,7 +14,7 @@ license: basic
categories:
- os_system
conditions:
kibana.version: ^7.14.0
kibana.version: "^7.16.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should bump the required Kibana version given that it's only changing the description.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @andrewkroh - sorry, I just looked at the updated description and missed the version bump.

@@ -1,8 +1,8 @@
name: auditd
title: Auditd
version: 1.2.3
version: 1.3.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 1.3.0
version: 1.2.4

How about a patch version bump given this is really minimal and introduces no new features.

@endorama
Copy link
Member Author

I removed the version constraint update and bumped patch instead of minor. Lets see if CI is happy today.

@endorama endorama merged commit 0664e50 into elastic:master Oct 27, 2021
@endorama endorama deleted the uniform-ui/auditd branch October 27, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants