-
Notifications
You must be signed in to change notification settings - Fork 457
[couchbase] Add Integration Package with Cluster Data Stream #3706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[couchbase] Add Integration Package with Cluster Data Stream #3706
Conversation
/test |
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hey @ManojS-shetty, this PR is kept in the draft stage as the PR for the first data stream (#3666) is waiting for review from the team. Otherwise, from the development perspective, this PR is completed. Feel free to review the same and provide your feedback. |
@bhagyaraj-crest I do not see any kibana dashboards here.Because of that i am not seeing any assets in integration page. |
The reason for not shipping the Kibana dashboards here is because there is a combined OOTB dashboard for bucket, cluster and nodes which we can either ship along with the last PR (nodes) or include as a part of a separate follow-up PR. Please let us know whatever suits the best for you. We have had the same discussion with the team earlier so that we can keep the PRs small, concise and easier to review, and agreed upon it. Please let me know if you have any other concerns with the PR. |
@bhagyaraj-crest Is there any specific requirement for the Operating system to run the system Test? i am running on the Mac OS docker desktop setup and the system test are not working for me as the pulling and bringing up couchbase container is failing on my laptop. Will this couchbase docker image supports Mac OS? |
Hey @ManojS-shetty, we try running the tests locally on our CentOS 7 machines and the tests are working fine. I see the tags mentioned in the Couchbase Docker image ( Could you please share more details on the issue that you are facing? |
…into package_couchbase_cluster
I am seeing the below error while running the command |
Hey @ManojS-shetty, I tried googling this issue quickly and found a similar discussion on one of the Stack Overflow questions. The issue seems to be specific to Mac. This was one of the proposed solutions out there, you might want to try it out.
However, as you mentioned, let's get this PR out as the CI is green so that we can go ahead with the next set of data streams. Please feel free to comment if you have any other concerns with the changes made as a part of this PR. |
Thanks for the approval, @ManojS-shetty! Just FYI, the current PR will also have changes similar to the follow up PR for bucket data stream as the changes are in the main manifest file which is common for all the integrations. |
What does this PR do?
Checklist
How to test this PR locally