Skip to content

IIS ignore older option #4212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 20, 2022
Merged

IIS ignore older option #4212

merged 6 commits into from
Sep 20, 2022

Conversation

muthu-mps
Copy link
Contributor

  • Enhancement

What does this PR do?

Adds support to ignore logs older than specified period. Details are in #3147

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

How to test this PR locally

Install IIS integration
Check for new ignore_older option is available for logs datastream.
Verify the log collection by specifying the value to the ignore_older option.

@muthu-mps muthu-mps self-assigned this Sep 14, 2022
@elasticmachine
Copy link

elasticmachine commented Sep 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-19T11:57:38.518+0000

  • Duration: 13 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 14, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 2.679
Classes 100.0% (2/2) 💚 2.679
Methods 85.714% (30/35) 👎 -4.045
Lines 91.781% (268/292) 👍 0.34
Conditionals 100.0% (0/0) 💚

@muthu-mps muthu-mps marked this pull request as ready for review September 14, 2022 09:11
@muthu-mps muthu-mps requested a review from a team as a code owner September 14, 2022 09:11
@elasticmachine
Copy link

elasticmachine commented Sep 19, 2022

🚀 Benchmarks report

Package iis 👍(1) 💚(1) 💔(0)

To see the full report comment with /test benchmark fullreport

Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@muthu-mps muthu-mps merged commit 454157f into elastic:main Sep 20, 2022
@muthu-mps muthu-mps deleted the iis_ignore_older branch September 21, 2022 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IIS Integration] Implement ignore_older for IIS integration Logs
3 participants