-
Notifications
You must be signed in to change notification settings - Fork 473
[AWS] Add Summary Dashboard for AWS Security Hub #4596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS] Add Summary Dashboard for AWS Security Hub #4596
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Could you add a screenshot as well please? Thanks! |
Hey @kaiyan-sheng i have attached the screenshot in the linked issue. Would you mind checking the same? edit: I've attached the same here as well. 😄 |
@vinit-elastic going by the screenshot, are all those resources in a single dashboards? If so, I wonder would we split it across smaller dashboards as there's currently a lot of information on one dashboard and a lot of scrolling involved. |
Hey @jamiehynds - Yes, it's a single dashboard, and agree with your point on scrolling. However, intention of this dashboard is to have all the essential details on a single pane. Therefore, a single dashboard. |
🚀 Benchmarks reportTo see the full report comment with |
🌐 Coverage report
|
Thanks!! I'm actually thinking to have it in https://github.com/elastic/integrations/tree/main/packages/aws/img as a sample. |
Looks nice and good job to use the new dashboard controls. Like @jamiehynds mentioned, this dashboard has a lot of visualizations in it. Our general guidance is to split large dashboards up along logical seams and connect them via
But, like I say, that's the general guidance. If you don't see a logical place to split this up for your use case, that's okay too 👍
Does it make sense to add links between these dashboards to assist the user in navigation? |
Hey @andrewctate - I couldn't think of any way to further divide the dashboard. However, I have added links to the other dashboards that are more specific to the findings and insights in this summary dashboard. Let me know if you need anything from my end. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @vinit-elastic !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. Just one nit: when you create the filters for integrations, account, region, you can use the new Controls
instead. But its up to you to change it or not :)
LGTM |
Type of change
What does this PR do?
Add Summary Dashboard for AWS Security Hub.
Checklist
changelog.yml
file.How to test this PR locally
Related issues
Screenshot