Skip to content

[AWS] Add Summary Dashboard for AWS Security Hub #4596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vinit-chauhan
Copy link
Contributor

@vinit-chauhan vinit-chauhan commented Nov 8, 2022

Type of change

  • Enhancement

What does this PR do?

Add Summary Dashboard for AWS Security Hub.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/aws directory.
  • Run the following command to run tests.

elastic-package test

Related issues

Screenshot

image

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@kaiyan-sheng
Copy link
Contributor

Could you add a screenshot as well please? Thanks!

@vinit-chauhan
Copy link
Contributor Author

vinit-chauhan commented Nov 8, 2022

Hey @kaiyan-sheng i have attached the screenshot in the linked issue. Would you mind checking the same?

edit: I've attached the same here as well. 😄

@jamiehynds
Copy link

@vinit-elastic going by the screenshot, are all those resources in a single dashboards? If so, I wonder would we split it across smaller dashboards as there's currently a lot of information on one dashboard and a lot of scrolling involved.

@vinit-chauhan
Copy link
Contributor Author

vinit-chauhan commented Nov 8, 2022

Hey @jamiehynds - Yes, it's a single dashboard, and agree with your point on scrolling. However, intention of this dashboard is to have all the essential details on a single pane. Therefore, a single dashboard.
And in any case, users can go to the separate dashboards ( the older ones ) of Insights and Findings that are shipped alongside this one.
Let me know if you think otherwise.

@elasticmachine
Copy link

elasticmachine commented Nov 8, 2022

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Nov 8, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-21T10:40:54.208+0000

  • Duration: 34 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 177
Skipped 3
Total 180

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 8, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (14/14) 💚
Files 93.333% (14/15) 👎 -3.725
Classes 93.333% (14/15) 👎 -3.725
Methods 85.098% (217/255) 👎 -3.811
Lines 95.949% (5897/6146) 👍 4.975
Conditionals 100.0% (0/0) 💚

@kaiyan-sheng
Copy link
Contributor

Hey @kaiyan-sheng i have attached the screenshot in the linked issue. Would you mind checking the same?

edit: I've attached the same here as well. 😄

Thanks!! I'm actually thinking to have it in https://github.com/elastic/integrations/tree/main/packages/aws/img as a sample.

@drewdaemon
Copy link
Contributor

Looks nice and good job to use the new dashboard controls. Like @jamiehynds mentioned, this dashboard has a lot of visualizations in it. Our general guidance is to split large dashboards up along logical seams and connect them via

But, like I say, that's the general guidance. If you don't see a logical place to split this up for your use case, that's okay too 👍

And in any case, users can go to the separate dashboards ( the older ones ) of Insights and Findings that are shipped alongside this one.

Does it make sense to add links between these dashboards to assist the user in navigation?

@vinit-chauhan
Copy link
Contributor Author

Hey @andrewctate - I couldn't think of any way to further divide the dashboard. However, I have added links to the other dashboards that are more specific to the findings and insights in this summary dashboard.

Let me know if you need anything from my end. 😄

Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vinit-elastic !

Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Just one nit: when you create the filters for integrations, account, region, you can use the new Controls instead. But its up to you to change it or not :)

@jamiehynds
Copy link

LGTM

@P1llus P1llus merged commit d7f0906 into elastic:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:aws AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Security Hub #3589: SecurityHub Dashboard Overview and other dashboard improvements
6 participants