Skip to content

[TSDB] [MySQL] Add metrictype mapping for MySQL status datastream #5387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 16, 2023
Merged

[TSDB] [MySQL] Add metrictype mapping for MySQL status datastream #5387

merged 9 commits into from
Mar 16, 2023

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Feb 25, 2023 •
edited
Loading

Type of change

  • Enhancement

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Related issues

@agithomas agithomas requested a review from a team as a code owner February 25, 2023 10:20
@agithomas agithomas changed the title Issue 5277 mysql status [TSDB] [MySQL] Add metrictype mapping for MySQL status datastream Feb 25, 2023
@agithomas agithomas force-pushed the issue-5277-mysql-status branch from a1c747b to 418a35e Compare February 25, 2023 10:27
@agithomas agithomas mentioned this pull request Feb 25, 2023
Closed
19 tasks
@elasticmachine
Copy link

elasticmachine commented Feb 25, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-16T09:49:43.163+0000

  • Duration: 34 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 74
Skipped 0
Total 74

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Feb 25, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 85.714% (24/28) ❕
Lines 93.706% (134/143) ❕
Conditionals 100.0% (0/0) 💚

ritalwar
ritalwar approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas merged commit 78da950 into elastic:main Mar 16, 2023
@elasticmachine
Copy link

Package mysql - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=mysql

agithomas added a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
@agithomas
[TSDB] [MySQL] Add metrictype mapping for MySQL status datastream (el…
04fbfda 
…astic#5387)

* Added the metric_type for status datastream

* Updated changelog and manifest
agithomas added a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
@agithomas
[TSDB] [MySQL] Add metrictype mapping for MySQL status datastream (el…
a18894e 
…astic#5387)

* Added the metric_type for status datastream

* Updated changelog and manifest
@agithomas agithomas deleted the issue-5277-mysql-status branch February 12, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritalwar ritalwar ritalwar approved these changes

Assignees
No one assigned
Labels
Integration:mysql MySQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agithomas @elasticmachine @ritalwar @andrewkroh