Skip to content

[AWS] Add the ignore_missing and null checks to rename processor #7933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 10, 2023

Conversation

ishleenk17
Copy link
Contributor

  • Bug

What does this PR do?

This PR adds the if check for event.original and the ignore_missing check for the renaming of message to event.original

Most of the AWS packages have already taken care of this check.
Some of the packages missing these have been addressed here:

  • cloudwatch_logs
  • gaurduty
  • inspector
  • securityhub_findings
  • securityhub_insights

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@ishleenk17 ishleenk17 requested a review from a team September 22, 2023 06:19
@ishleenk17 ishleenk17 changed the title Add the ignore_missing and null checks to rename processor [AWS] Add the ignore_missing and null checks to rename processor Sep 22, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 22, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-10T05:22:56.888+0000

  • Duration: 56 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 212
Skipped 3
Total 215

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 22, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👎 -2.243
Classes 94.444% (17/18) 👎 -2.243
Methods 86.047% (259/301) 👎 -6.315
Lines 86.083% (7571/8795) 👎 -2.331
Conditionals 100.0% (0/0) 💚

@ishleenk17 ishleenk17 marked this pull request as ready for review September 22, 2023 09:35
@ishleenk17 ishleenk17 requested review from a team as code owners September 22, 2023 09:35
@ishleenk17 ishleenk17 self-assigned this Sep 22, 2023
@elasticmachine
Copy link

Package aws - 2.8.2 containing this change is available at https://epr.elastic.co/search?package=aws

@ishleenk17 ishleenk17 deleted the aws_nullchecks branch February 7, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants