Skip to content

[azure_metrics] Enable tsds on all remaining datastreams #8680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tetianakravchenko
Copy link
Contributor

Proposed commit message

Enable tsds on all remaining datastreams

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Tested with TSDB-migration-test-kit

  1. install integration version 1.3.0 - gather some data
  2. upgrade integration to 1.4.0.
  3. to run TSDB-migration-test-kit set settings:
"docs_index": 0,   ## an index 000001 (tsds not enabled yet)
"settings_mappings_index": 1,  ## use settings from the index `000002` (tsds enabled)

Related issues

Screenshots

@tetianakravchenko tetianakravchenko requested a review from a team as a code owner December 8, 2023 10:21
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Dec 8, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-08T10:22:40.776+0000

  • Duration: 16 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 34
Skipped 0
Total 34

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 75.758% (25/33) 👎 -19.555
Lines 100.0% (32/32) 💚 9.945
Conditionals 100.0% (0/0) 💚

@tetianakravchenko tetianakravchenko merged commit a1a0fa1 into elastic:main Dec 8, 2023
@elasticmachine
Copy link

Package azure_metrics - 1.4.0 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

@andrewkroh andrewkroh added the Integration:azure_metrics Azure Resource Metrics label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:azure_metrics Azure Resource Metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Azure] TSDB enablement - track all metrics data streams
4 participants