Skip to content

initial commit for storage dashboard in ES integration #8689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 8, 2024

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Dec 11, 2023

No description provided.

@jsvd jsvd marked this pull request as ready for review December 11, 2023 11:41
@jsvd jsvd requested a review from a team as a code owner December 11, 2023 11:41
@elasticmachine
Copy link

elasticmachine commented Dec 11, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-14T15:24:02.177+0000

  • Duration: 36 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 62
Skipped 0
Total 62

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Dec 11, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 87.5% (98/112)
Lines 91.993% (563/612)
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@miltonhultgren miltonhultgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the dashboards and they work. My only feedback would be to consider aligning the naming of the dashboards with those added for Ingest Pipeline monitoring.

Screenshot 2023-12-14 at 12 46 33

@jsvd
Copy link
Member Author

jsvd commented Dec 14, 2023

Done: ba40c10
@miltonhultgren thanks for the feedback

@jsvd jsvd requested a review from miltonhultgren December 14, 2023 15:25
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@jsvd jsvd requested a review from jsoriano December 19, 2023 10:11
@jsvd
Copy link
Member Author

jsvd commented Dec 19, 2023

@jsoriano taking up your offer to look at this PR, I set you up as a reviewer. thanks!

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Consider adding screenshots of the dashboards. They can be added to the img directory and referenced in the manifest.

@mrodm
Copy link
Collaborator

mrodm commented Dec 21, 2023

Hi @jsvd, please update your branch with the latest contents from main branch. There was an important PR merged updating the CI pipelines. Thanks!

@jsvd jsvd force-pushed the es_storage_dashboard branch from ba40c10 to cf0218a Compare December 21, 2023 11:44
@jsvd
Copy link
Member Author

jsvd commented Dec 21, 2023

@mrodm rebase done!
@jsoriano neat! I'll work on getting some screenshots when I'm back from PTO next year.

@jsvd jsvd force-pushed the es_storage_dashboard branch from cf0218a to a929985 Compare January 2, 2024 14:49
@jsvd jsvd requested a review from jsoriano January 3, 2024 12:19
@jsvd
Copy link
Member Author

jsvd commented Jan 3, 2024

@jsoriano screenshots added, looking for final LGTM. thanks!

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsoriano screenshots added, looking for final LGTM. thanks!

Nice, thanks!

@jsvd jsvd merged commit b7e2f0e into elastic:main Jan 8, 2024
@jsvd jsvd deleted the es_storage_dashboard branch January 8, 2024 09:20
@elasticmachine
Copy link

Package elasticsearch - 1.12.0 containing this change is available at https://epr.elastic.co/search?package=elasticsearch

@IanLee1521
Copy link
Contributor

@jsvd / whomever - I've been using these dashboards recently and am having some issues with them in our environment, what's the best way to provide feedback? Open a new issue?

@jsvd
Copy link
Member Author

jsvd commented Sep 2, 2024

Hi @IanLee1521 yes a new issue on this repo would be the right approach! /cc @flexitrev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants