-
Notifications
You must be signed in to change notification settings - Fork 457
initial commit for storage dashboard in ES integration #8689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: ba40c10 |
🚀 Benchmarks reportTo see the full report comment with |
@jsoriano taking up your offer to look at this PR, I set you up as a reviewer. thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Consider adding screenshots of the dashboards. They can be added to the img
directory and referenced in the manifest.
Hi @jsvd, please update your branch with the latest contents from main branch. There was an important PR merged updating the CI pipelines. Thanks! |
ba40c10
to
cf0218a
Compare
cf0218a
to
a929985
Compare
@jsoriano screenshots added, looking for final LGTM. thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsoriano screenshots added, looking for final LGTM. thanks!
Nice, thanks!
Package elasticsearch - 1.12.0 containing this change is available at https://epr.elastic.co/search?package=elasticsearch |
@jsvd / whomever - I've been using these dashboards recently and am having some issues with them in our environment, what's the best way to provide feedback? Open a new issue? |
Hi @IanLee1521 yes a new issue on this repo would be the right approach! /cc @flexitrev |
No description provided.