[Streams 🌊] Remove enablement check in `PUT /api/streams/{id}` for classic streams #212289

simianhacker · 2025-02-24T17:25:34Z

Summary

The goal of this PR is to enable all the workflows for "Classic" without enabling "Wired" streams. This PR changes the isStreamsEnabled check for PUT /api/streams/{id} to allow for PUT requests for an UnwiredStreamDefinition. This change will allow users to directly navigate to /app/streams and use it to manage "classic" streams. User's would still be required to call POST /api/streams/_enable to work with "wired" streams.

This also includes a fix for the i18n paths that were missed when moving from Observability to Platform.

…assic streams

…classic

flash1293

Everything that should work does work, but via the _ingest endpoint it's still possible to write wired streams without explicitly calling the _enable endpoint:

PUT kbn:/api/streams/logs/_ingest
{
    "ingest": {
    "lifecycle": {
      "ilm": {
        "policy": "logs@lifecycle"
      }
    },
    "routing": [],
    "processing": [],
    "wired": {
      "fields": {
        "@timestamp": {
          "type": "date"
        },
        "message": {
          "type": "match_only_text"
        },
        "host.name": {
          "type": "keyword"
        },
        "log.level": {
          "type": "keyword"
        },
        "stream.name": {
          "type": "keyword"
        }
      }
   
    }
  } 
}

This isn't a new thing and I think it's not a big problem - after all enabling isn't anything else but creating that root stream.

Only thing we might need to change is what _disable is doing - right now this wipes the whole thing (including our hidden tracking indices). It's not important for the first release but I guess people would want to disable only the root logs stream without also deleting all the stuff they configured for classic streams as well.

We can also target that once we get to the first release of wired streams, but feel free to account for that now (e.g. we could have explicit _disable for everything and _disable_wired for just wired streams

x-pack/.i18nrc.json

x-pack/test/api_integration/deployment_agnostic/apis/observability/streams/classic.ts

…classic

simianhacker · 2025-02-25T19:08:56Z

@flash1293 I added the checks to _group and _ingest... give it another look. I'll defer on the _disable since that seem more appropriate for a seperate PR.

flash1293

Still looks good to me after one small nit is addressed.

flash1293 · 2025-02-26T16:20:02Z

x-pack/platform/plugins/shared/streams/server/routes/streams/ingest/route.ts

@@ -75,6 +75,13 @@ const upsertIngestRoute = createServerRoute({
      request,
    });

+    if (
+      !(await streamsClient.isStreamsEnabled()) &&
+      isWiredStreamDefinition({ name: params.path.name, ...params.body })


Flipping these conditions around will save us an async call to streamsClient.isStreamsEnabled in the happy path

…classic

kibanamachine · 2025-02-27T01:36:18Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13556983938

elasticmachine · 2025-02-27T01:36:35Z

💚 Build Succeeded

Buildkite Build
Commit: a8c610d

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`streamsAppWrapper`	4.7KB	4.7KB	-30.0B

History

💚 Build #279126 succeeded 9e59416
💛 Build #278951 was flaky 8eb21e9

kibanamachine · 2025-02-27T01:41:48Z

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 212289

Questions ?

Please refer to the Backport tool documentation

…assic streams (elastic#212289) ## Summary The goal of this PR is to enable all the workflows for "Classic" without enabling "Wired" streams. This PR changes the `isStreamsEnabled` check for `PUT /api/streams/{id}` to allow for `PUT` requests for an `UnwiredStreamDefinition`. This change will allow users to directly navigate to `/app/streams` and use it to manage "classic" streams. User's would still be required to call `POST /api/streams/_enable` to work with "wired" streams. This also includes a fix for the `i18n` paths that were missed when moving from Observability to Platform.

simianhacker · 2025-02-28T14:24:20Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…assic streams (elastic#212289) ## Summary The goal of this PR is to enable all the workflows for "Classic" without enabling "Wired" streams. This PR changes the `isStreamsEnabled` check for `PUT /api/streams/{id}` to allow for `PUT` requests for an `UnwiredStreamDefinition`. This change will allow users to directly navigate to `/app/streams` and use it to manage "classic" streams. User's would still be required to call `POST /api/streams/_enable` to work with "wired" streams. This also includes a fix for the `i18n` paths that were missed when moving from Observability to Platform. (cherry picked from commit b797617) # Conflicts: # x-pack/.i18nrc.json

kibanamachine · 2025-03-03T01:48:39Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

…for classic streams (#212289) (#212779) # Backport This will backport the following commits from `main` to `8.x`: - [[Streams 🌊] Remove enablement check in `PUT /api/streams/{id}` for classic streams (#212289)](#212289)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Elastic Machine <[email protected]>

…for classic streams (elastic#212289) (elastic#212779) # Backport This will backport the following commits from `main` to `8.x`: - [[Streams 🌊] Remove enablement check in `PUT /api/streams/{id}` for classic streams (elastic#212289)](elastic#212289)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Elastic Machine <[email protected]>

…assic streams (elastic#212289) ## Summary The goal of this PR is to enable all the workflows for "Classic" without enabling "Wired" streams. This PR changes the `isStreamsEnabled` check for `PUT /api/streams/{id}` to allow for `PUT` requests for an `UnwiredStreamDefinition`. This change will allow users to directly navigate to `/app/streams` and use it to manage "classic" streams. User's would still be required to call `POST /api/streams/_enable` to work with "wired" streams. This also includes a fix for the `i18n` paths that were missed when moving from Observability to Platform.

simianhacker added 3 commits February 24, 2025 10:20

[Streams 🌊] Remove enablement check in PUT /api/streams/{id} for cl…

aa1a9aa

…assic streams

Merge branch 'main' of github.com:elastic/kibana into streams/enable-…

f6d1e23

…classic

Removing call for enabling and disabling streams

8eb21e9

simianhacker added backport:version Backport to applied version labels v9.1.0 v8.19.0 Feature:Streams This is the label for the Streams Project labels Feb 24, 2025

simianhacker marked this pull request as ready for review February 24, 2025 18:52

simianhacker requested a review from a team as a code owner February 24, 2025 18:52

simianhacker added release_note:fix release_note:enhancement and removed release_note:fix labels Feb 24, 2025

flash1293 approved these changes Feb 25, 2025

View reviewed changes

x-pack/.i18nrc.json Show resolved Hide resolved

x-pack/test/api_integration/deployment_agnostic/apis/observability/streams/classic.ts Outdated Show resolved Hide resolved

simianhacker added 3 commits February 25, 2025 07:04

removing commented out code

ce911d0

Locking down _ingest and _group endpoints

b7194fc

Merge branch 'main' of github.com:elastic/kibana into streams/enable-…

9e59416

…classic

simianhacker requested a review from flash1293 February 25, 2025 16:43

flash1293 approved these changes Feb 26, 2025

View reviewed changes

simianhacker added 2 commits February 26, 2025 14:22

moving the async isStreamsEnabled call to the second condition

c20e2ba

Merge branch 'main' of github.com:elastic/kibana into streams/enable-…

9ee0373

…classic

simianhacker enabled auto-merge (squash) February 26, 2025 23:22

Merge branch 'main' of github.com:elastic/kibana into streams/enable-…

a8c610d

…classic

simianhacker merged commit b797617 into elastic:main Feb 27, 2025
10 checks passed

simianhacker mentioned this pull request Feb 28, 2025

[8.x] [Streams 🌊] Remove enablement check in PUT /api/streams/{id} for classic streams (#212289) #212779

Merged

kibanamachine mentioned this pull request Feb 28, 2025

[Automatic Import] Fixes the CSV header bug #212513

Merged

7 tasks

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 3, 2025

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Streams 🌊] Remove enablement check in `PUT /api/streams/{id}` for classic streams #212289

[Streams 🌊] Remove enablement check in `PUT /api/streams/{id}` for classic streams #212289

Uh oh!

simianhacker commented Feb 24, 2025 •

edited by kibanamachine

Loading

Uh oh!

flash1293 left a comment

Uh oh!

Uh oh!

Uh oh!

simianhacker commented Feb 25, 2025

Uh oh!

flash1293 left a comment

Uh oh!

flash1293 Feb 26, 2025

Uh oh!

Uh oh!

kibanamachine commented Feb 27, 2025

Uh oh!

elasticmachine commented Feb 27, 2025

Uh oh!

kibanamachine commented Feb 27, 2025

Uh oh!

simianhacker commented Feb 28, 2025

Uh oh!

kibanamachine commented Mar 3, 2025

Uh oh!

Uh oh!

[Streams 🌊] Remove enablement check in PUT /api/streams/{id} for classic streams #212289

[Streams 🌊] Remove enablement check in PUT /api/streams/{id} for classic streams #212289

Uh oh!

Conversation

simianhacker commented Feb 24, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

simianhacker commented Feb 25, 2025

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

flash1293 Feb 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Feb 27, 2025

Uh oh!

elasticmachine commented Feb 27, 2025

💚 Build Succeeded

Metrics [docs]

Page load bundle

History

Uh oh!

kibanamachine commented Feb 27, 2025

💔 All backports failed

Manual backport

Questions ?

Uh oh!

simianhacker commented Feb 28, 2025

💚 All backports created successfully

Questions ?

Uh oh!

kibanamachine commented Mar 3, 2025

Uh oh!

Uh oh!

[Streams 🌊] Remove enablement check in `PUT /api/streams/{id}` for classic streams #212289

[Streams 🌊] Remove enablement check in `PUT /api/streams/{id}` for classic streams #212289

simianhacker commented Feb 24, 2025 •

edited by kibanamachine

Loading