Skip to content

[Synthetics] Fixed alert count in monitor details #216761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

cesco-f
Copy link
Contributor

@cesco-f cesco-f commented Apr 2, 2025

This PR closes #191328

Before:
Screenshot 2025-04-02 at 10 38 42

After:
Screenshot 2025-04-02 at 10 38 21

@cesco-f cesco-f added release_note:fix backport:version Backport to applied version labels v8.19.0 labels Apr 2, 2025
@cesco-f cesco-f requested a review from a team as a code owner April 2, 2025 08:40
@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Apr 2, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #15 / should filter the table correctly

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 979.2KB 979.3KB +52.0B

History

Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a question: is this hook only used in this tab badge?

@cesco-f
Copy link
Contributor Author

cesco-f commented Apr 7, 2025

LGTM. Just a question: is this hook only used in this tab badge?

It is, there is another useFetchActiveAlerts hook in the codebase but this one in particular is only used in the alerts_icon.tsx file.

@cesco-f cesco-f merged commit aa37d53 into elastic:main Apr 7, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.18, 8.x, 9.0

https://github.com/elastic/kibana/actions/runs/14310922908

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 7, 2025
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 7, 2025
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 7, 2025
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 7, 2025
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.17
8.18
8.x
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@cesco-f cesco-f deleted the fix-alert-count branch April 7, 2025 14:22
kibanamachine added a commit that referenced this pull request Apr 7, 2025
…217337)

# Backport

This will backport the following commits from `main` to `8.18`:
- [[Synthetics] Fixed alert count in monitor details
(#216761)](#216761)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Francesco
Fagnani","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-04-07T13:47:40Z","message":"[Synthetics]
Fixed alert count in monitor details (#216761)\n\nThis PR closes #191328
\n\nBefore:\n<img width=\"1512\" alt=\"Screenshot 2025-04-02 at 10 38
42\"\nsrc=\"https://github.com/user-attachments/assets/d4c9c744-afdf-4d1b-8bd9-9447c0945258\"\n/>\n\nAfter:\n<img
width=\"758\" alt=\"Screenshot 2025-04-02 at 10 38
21\"\nsrc=\"https://github.com/user-attachments/assets/c2692a44-db8c-461b-803c-d1834646d514\"\n/>","sha":"aa37d539fb2ea9340a9ac100a91ea36b2424e5c0","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1","v8.17.5"],"title":"[Synthetics]
Fixed alert count in monitor
details","number":216761,"url":"https://github.com/elastic/kibana/pull/216761","mergeCommit":{"message":"[Synthetics]
Fixed alert count in monitor details (#216761)\n\nThis PR closes #191328
\n\nBefore:\n<img width=\"1512\" alt=\"Screenshot 2025-04-02 at 10 38
42\"\nsrc=\"https://github.com/user-attachments/assets/d4c9c744-afdf-4d1b-8bd9-9447c0945258\"\n/>\n\nAfter:\n<img
width=\"758\" alt=\"Screenshot 2025-04-02 at 10 38
21\"\nsrc=\"https://github.com/user-attachments/assets/c2692a44-db8c-461b-803c-d1834646d514\"\n/>","sha":"aa37d539fb2ea9340a9ac100a91ea36b2424e5c0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18","9.0","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216761","number":216761,"mergeCommit":{"message":"[Synthetics]
Fixed alert count in monitor details (#216761)\n\nThis PR closes #191328
\n\nBefore:\n<img width=\"1512\" alt=\"Screenshot 2025-04-02 at 10 38
42\"\nsrc=\"https://github.com/user-attachments/assets/d4c9c744-afdf-4d1b-8bd9-9447c0945258\"\n/>\n\nAfter:\n<img
width=\"758\" alt=\"Screenshot 2025-04-02 at 10 38
21\"\nsrc=\"https://github.com/user-attachments/assets/c2692a44-db8c-461b-803c-d1834646d514\"\n/>","sha":"aa37d539fb2ea9340a9ac100a91ea36b2424e5c0"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Francesco Fagnani <[email protected]>
kibanamachine added a commit that referenced this pull request Apr 7, 2025
…17338)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Synthetics] Fixed alert count in monitor details
(#216761)](#216761)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Francesco
Fagnani","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-04-07T13:47:40Z","message":"[Synthetics]
Fixed alert count in monitor details (#216761)\n\nThis PR closes #191328
\n\nBefore:\n<img width=\"1512\" alt=\"Screenshot 2025-04-02 at 10 38
42\"\nsrc=\"https://github.com/user-attachments/assets/d4c9c744-afdf-4d1b-8bd9-9447c0945258\"\n/>\n\nAfter:\n<img
width=\"758\" alt=\"Screenshot 2025-04-02 at 10 38
21\"\nsrc=\"https://github.com/user-attachments/assets/c2692a44-db8c-461b-803c-d1834646d514\"\n/>","sha":"aa37d539fb2ea9340a9ac100a91ea36b2424e5c0","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1","v8.17.5"],"title":"[Synthetics]
Fixed alert count in monitor
details","number":216761,"url":"https://github.com/elastic/kibana/pull/216761","mergeCommit":{"message":"[Synthetics]
Fixed alert count in monitor details (#216761)\n\nThis PR closes #191328
\n\nBefore:\n<img width=\"1512\" alt=\"Screenshot 2025-04-02 at 10 38
42\"\nsrc=\"https://github.com/user-attachments/assets/d4c9c744-afdf-4d1b-8bd9-9447c0945258\"\n/>\n\nAfter:\n<img
width=\"758\" alt=\"Screenshot 2025-04-02 at 10 38
21\"\nsrc=\"https://github.com/user-attachments/assets/c2692a44-db8c-461b-803c-d1834646d514\"\n/>","sha":"aa37d539fb2ea9340a9ac100a91ea36b2424e5c0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18","9.0","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216761","number":216761,"mergeCommit":{"message":"[Synthetics]
Fixed alert count in monitor details (#216761)\n\nThis PR closes #191328
\n\nBefore:\n<img width=\"1512\" alt=\"Screenshot 2025-04-02 at 10 38
42\"\nsrc=\"https://github.com/user-attachments/assets/d4c9c744-afdf-4d1b-8bd9-9447c0945258\"\n/>\n\nAfter:\n<img
width=\"758\" alt=\"Screenshot 2025-04-02 at 10 38
21\"\nsrc=\"https://github.com/user-attachments/assets/c2692a44-db8c-461b-803c-d1834646d514\"\n/>","sha":"aa37d539fb2ea9340a9ac100a91ea36b2424e5c0"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Francesco Fagnani <[email protected]>
kibanamachine added a commit that referenced this pull request Apr 7, 2025
…217336)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Synthetics] Fixed alert count in monitor details
(#216761)](#216761)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Francesco
Fagnani","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-04-07T13:47:40Z","message":"[Synthetics]
Fixed alert count in monitor details (#216761)\n\nThis PR closes #191328
\n\nBefore:\n<img width=\"1512\" alt=\"Screenshot 2025-04-02 at 10 38
42\"\nsrc=\"https://github.com/user-attachments/assets/d4c9c744-afdf-4d1b-8bd9-9447c0945258\"\n/>\n\nAfter:\n<img
width=\"758\" alt=\"Screenshot 2025-04-02 at 10 38
21\"\nsrc=\"https://github.com/user-attachments/assets/c2692a44-db8c-461b-803c-d1834646d514\"\n/>","sha":"aa37d539fb2ea9340a9ac100a91ea36b2424e5c0","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1","v8.17.5"],"title":"[Synthetics]
Fixed alert count in monitor
details","number":216761,"url":"https://github.com/elastic/kibana/pull/216761","mergeCommit":{"message":"[Synthetics]
Fixed alert count in monitor details (#216761)\n\nThis PR closes #191328
\n\nBefore:\n<img width=\"1512\" alt=\"Screenshot 2025-04-02 at 10 38
42\"\nsrc=\"https://github.com/user-attachments/assets/d4c9c744-afdf-4d1b-8bd9-9447c0945258\"\n/>\n\nAfter:\n<img
width=\"758\" alt=\"Screenshot 2025-04-02 at 10 38
21\"\nsrc=\"https://github.com/user-attachments/assets/c2692a44-db8c-461b-803c-d1834646d514\"\n/>","sha":"aa37d539fb2ea9340a9ac100a91ea36b2424e5c0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18","9.0","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216761","number":216761,"mergeCommit":{"message":"[Synthetics]
Fixed alert count in monitor details (#216761)\n\nThis PR closes #191328
\n\nBefore:\n<img width=\"1512\" alt=\"Screenshot 2025-04-02 at 10 38
42\"\nsrc=\"https://github.com/user-attachments/assets/d4c9c744-afdf-4d1b-8bd9-9447c0945258\"\n/>\n\nAfter:\n<img
width=\"758\" alt=\"Screenshot 2025-04-02 at 10 38
21\"\nsrc=\"https://github.com/user-attachments/assets/c2692a44-db8c-461b-803c-d1834646d514\"\n/>","sha":"aa37d539fb2ea9340a9ac100a91ea36b2424e5c0"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Francesco Fagnani <[email protected]>
kibanamachine added a commit that referenced this pull request Apr 7, 2025
…17339)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[Synthetics] Fixed alert count in monitor details
(#216761)](#216761)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Francesco
Fagnani","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-04-07T13:47:40Z","message":"[Synthetics]
Fixed alert count in monitor details (#216761)\n\nThis PR closes #191328
\n\nBefore:\n<img width=\"1512\" alt=\"Screenshot 2025-04-02 at 10 38
42\"\nsrc=\"https://github.com/user-attachments/assets/d4c9c744-afdf-4d1b-8bd9-9447c0945258\"\n/>\n\nAfter:\n<img
width=\"758\" alt=\"Screenshot 2025-04-02 at 10 38
21\"\nsrc=\"https://github.com/user-attachments/assets/c2692a44-db8c-461b-803c-d1834646d514\"\n/>","sha":"aa37d539fb2ea9340a9ac100a91ea36b2424e5c0","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1","v8.17.5"],"title":"[Synthetics]
Fixed alert count in monitor
details","number":216761,"url":"https://github.com/elastic/kibana/pull/216761","mergeCommit":{"message":"[Synthetics]
Fixed alert count in monitor details (#216761)\n\nThis PR closes #191328
\n\nBefore:\n<img width=\"1512\" alt=\"Screenshot 2025-04-02 at 10 38
42\"\nsrc=\"https://github.com/user-attachments/assets/d4c9c744-afdf-4d1b-8bd9-9447c0945258\"\n/>\n\nAfter:\n<img
width=\"758\" alt=\"Screenshot 2025-04-02 at 10 38
21\"\nsrc=\"https://github.com/user-attachments/assets/c2692a44-db8c-461b-803c-d1834646d514\"\n/>","sha":"aa37d539fb2ea9340a9ac100a91ea36b2424e5c0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18","9.0","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216761","number":216761,"mergeCommit":{"message":"[Synthetics]
Fixed alert count in monitor details (#216761)\n\nThis PR closes #191328
\n\nBefore:\n<img width=\"1512\" alt=\"Screenshot 2025-04-02 at 10 38
42\"\nsrc=\"https://github.com/user-attachments/assets/d4c9c744-afdf-4d1b-8bd9-9447c0945258\"\n/>\n\nAfter:\n<img
width=\"758\" alt=\"Screenshot 2025-04-02 at 10 38
21\"\nsrc=\"https://github.com/user-attachments/assets/c2692a44-db8c-461b-803c-d1834646d514\"\n/>","sha":"aa37d539fb2ea9340a9ac100a91ea36b2424e5c0"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Francesco Fagnani <[email protected]>
baileycash-elastic pushed a commit to baileycash-elastic/kibana that referenced this pull request Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:fix Team:obs-ux-management Observability Management User Experience Team v8.17.5 v8.18.0 v8.19.0 v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Synthetics] Monitor details - Alerts tab - Alerts tab shows alert count when there are no active alerts
6 participants