Skip to content

feat: promisify webContents.hasServiceWorker() #16535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codebytere merged 2 commits into from
Jan 26, 2019
Merged

feat: promisify webContents.hasServiceWorker() #16535

codebytere merged 2 commits into from
Jan 26, 2019

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Jan 24, 2019 •
edited
Loading

Description of Change

Promifisify contents.hasServiceWorker().

cc @ckerr @MarshallOfSound

Checklist

Release Notes

Notes: Converted webContents.hasServiceWorker() to return a promise instead of taking a callback.

@codebytere codebytere requested review from a team January 24, 2019 19:15
@codebytere codebytere force-pushed the promisify-hasserviceworker branch 3 times, most recently from a101706 to f25b37d Compare January 24, 2019 20:43
@codebytere codebytere force-pushed the promisify-hasserviceworker branch from 38d152e to 767c1bc Compare January 26, 2019 00:31
@codebytere codebytere changed the title feat: promisify contents.hasServiceWorker() feat: promisify ServiceWorker APIs Jan 26, 2019
@codebytere codebytere changed the title feat: promisify ServiceWorker APIs feat: promisify webContents.hasServiceWorker() Jan 26, 2019
@codebytere codebytere merged commit d105dcc into master Jan 26, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 26, 2019

Release Notes Persisted

Converted webContents.hasServiceWorker() to return a promise instead of taking a callback.

@codebytere codebytere deleted the promisify-hasserviceworker branch January 26, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckerr ckerr ckerr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@codebytere @ckerr