Skip to content

perf: on Windows, make Archive::HeaderIntegrity() faster #46537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Apr 7, 2025

Backport of #46509

See that PR for details.

Notes: Improved ASAR integrity checks on Windows.

trop bot and others added 13 commits April 7, 2025 09:10
remove unnecessary std::optional<>

Co-authored-by: Charles Kerr <[email protected]>
Co-authored-by: Charles Kerr <[email protected]>
refator: put LoadIntegrityConfig() in an unnamed namespace

Co-authored-by: Charles Kerr <[email protected]>
@trop trop bot requested review from ckerr and a team April 7, 2025 09:12
@trop trop bot added 36-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Apr 7, 2025
@ckerr ckerr merged commit 4392cb9 into 36-x-y Apr 7, 2025
60 checks passed
@ckerr ckerr deleted the trop/36-x-y-bp-perf-on-windows-make-archive-headerintegrity-faster-1744017034955 branch April 7, 2025 15:16
@release-clerk
Copy link

release-clerk bot commented Apr 7, 2025

Release Notes Persisted

Improved ASAR integrity checks on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
36-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant