Skip to content

chore: update Go to 1.24 to resolve the build error #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Mar 7, 2025

The release v1.11.8 failed because the version of Go was too old (v1.18.0).

https://github.com/fe3dback/go-arch-lint/releases/tag/v1.11.8
https://github.com/fe3dback/go-arch-lint/actions/runs/13710094273/job/38344571507

Error:     │ build failed: exit status 1: ../../../go/pkg/mod/golang.org/x/[email protected]/go/packages/external.go:16:2: package slices is not in GOROOT (/opt/hostedtoolcache/go/1.18.10/x64/src/slices)
    target=linux_arm64_v8.0

slices package requires Go 1.21 or newer.

Test

The release succeeded.

https://github.com/suzuki-shunsuke/go-arch-lint/actions/runs/13719517471/job/38371666569
https://github.com/suzuki-shunsuke/go-arch-lint/releases/tag/v1.11.9

https://github.com/fe3dback/go-arch-lint/actions/runs/13710094273/job/38344571507

```
Error:     │ build failed: exit status 1: ../../../go/pkg/mod/golang.org/x/[email protected]/go/packages/external.go:16:2: package slices is not in GOROOT (/opt/hostedtoolcache/go/1.18.10/x64/src/slices)
    target=linux_arm64_v8.0
```
@fe3dback fe3dback merged commit aaee6cc into fe3dback:master Mar 7, 2025
@github-project-automation github-project-automation bot moved this to Done in main Mar 7, 2025
@fe3dback
Copy link
Owner

fe3dback commented Mar 7, 2025

Oh, thanks, I didn't see it yesterday.

@suzuki-shunsuke suzuki-shunsuke deleted the chore-update-go-124 branch March 7, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants