Skip to content

Fix impossible parse_url equality #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2018
Merged

Conversation

muglug
Copy link
Contributor

@muglug muglug commented Oct 4, 2018

parse_url returns false for malformed urls, not null

@codecov
Copy link

codecov bot commented Oct 4, 2018

Codecov Report

Merging #676 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #676   +/-   ##
=========================================
  Coverage     81.83%   81.83%           
  Complexity      883      883           
=========================================
  Files            44       44           
  Lines          1993     1993           
=========================================
  Hits           1631     1631           
  Misses          362      362
Impacted Files Coverage Δ Complexity Δ
src/utils.php 85.36% <100%> (ø) 0 <0> (ø) ⬇️

@felixfbecker felixfbecker merged commit ed2d8dd into felixfbecker:master Nov 11, 2018
@felixfbecker
Copy link
Owner

🎉 This PR is included in version 5.4.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants