This repository was archived by the owner on Dec 5, 2024. It is now read-only.
This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Exiting early on sign in with 2FA appear to be sign user in #686
Closed
Description
Description
If I begin to sign in with 2FA but then don't enter a 2FA code, I appear to be authenticated in Unity.
Steps to Reproduce
- Start signed out
- Select sign in
- Enter username and password
- At the 2FA step, close the dialog
Expected behavior:
To not be signed in
Actual behavior:
I appear to be signed in:
Go to profile
is successful
But then when I went to publish the repo I got this:
Reproduces how often:
100%
Additional Information
Logs that might be helpful:
180410-10:39:10.735 TRACE [104] <ProcessWrapper> Running '/Applications/Unity 2017.2.0f3/Unity.app/Contents/Tools/nodejs/bin/node "/Users/meaghanlewis/Library/Application Support/GitHubUnity/octorun/src/bin/app.js" login'
180410-10:39:11.683 TRACE [105] <ProcessWrapper> Running '/usr/local/bin/git credential-osxkeychain erase'
180410-10:39:12.140 TRACE [106] <ProcessWrapper> Running '/usr/local/bin/git credential-osxkeychain store'
180410-10:39:13.050 TRACE [ 1] <AuthenticationView> Starting 2FA - Message:"Two Factor Required."
180410-10:39:25.263 TRACE [107] <ProcessWrapper> Running '/Applications/Unity 2017.2.0f3/Unity.app/Contents/Tools/nodejs/bin/node "/Users/meaghanlewis/Library/Application Support/GitHubUnity/octorun/src/bin/app.js" validate'
180410-10:39:25.507 TRACE [66] <RepositoryManager> WatcherOnRepositoryChanged
180410-10:39:25.570 TRACE [ 1] <GitStatusCache> Invalidate
180410-10:39:25.579 TRACE [108] <ProcessWrapper> Running '/usr/local/bin/git -c i18n.logoutputencoding=utf8 -c core.quotepath=false status -b -u --porcelain'
180410-10:39:25.668 TRACE [108] <RepositoryManager> IsBusyChanged Value:True
180410-10:39:25.760 TRACE [110] <RepositoryManager> IsBusyChanged Value:False
180410-10:39:25.874 TRACE [ 1] <GitStatusCache> 04/10/2018 10:39:25 -07:00 Updating Entries: current:0 new:0
180410-10:39:25.881 TRACE [ 1] <GitAheadBehindCache> 04/10/2018 10:39:25 -07:00 Updating Ahead: current:0 new:0
180410-10:39:25.883 TRACE [ 1] <GitAheadBehindCache> 04/10/2018 10:39:25 -07:00 Updating Behind: current:0 new:0
180410-10:39:26.500 ERROR [ 1] <ApiClient> Error Getting Current User
GitHub.Unity.ApiClientException: Bad credentials
at GitHub.Unity.ApiClient+<GetValidatedGitHubUser>c__asyncD.MoveNext () [0x00194] in C:\Users\Spade\Projects\GitHub\Unity\src\GitHub.Api\Application\ApiClient.cs:342
=======
at GitHub.Unity.ApiClient+<GetValidatedGitHubUser>c__asyncD.MoveNext() in C:\Users\Spade\Projects\GitHub\Unity\src\GitHub.Api\Application\ApiClient.cs:line 351
at System.Runtime.CompilerServices.AsyncMethodBuilderCore+MoveNextRunner.InvokeMoveNext(System.Object stateMachine)
at System.Security.SecurityContext.Run(System.Security.SecurityContext securityContext, System.Threading.ContextCallback callback, System.Object state) in /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.Security/SecurityContext.cs:line 150
at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state) in /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.Threading/ExecutionContext.cs:line 150
at System.Runtime.CompilerServices.AsyncMethodBuilderCore+MoveNextRunner.Run()
at System.Runtime.CompilerServices.TaskAwaiter+<>c.<OnCompletedInternal>b__17_1(System.Object state)
at GitHub.Unity.MainThreadSynchronizationContext+<Post>c__AnonStorey1.<>m__0() in C:\Users\Spade\Projects\GitHub\Unity\src\UnityExtension\Assets\Editor\GitHub.Unity\Threading\SingleThreadSynchronizationContext.cs:line 20