Icons placed incorrectly on files without icons

[meaghanlewis]

The icons are places over the text of the file name in the case that the file does not have an icon under Changes.

Steps to Reproduce

1. Create new project with asset package or multiple asset packages. (I believe I used Roll-a-ball tutorial)
   
2. Initialize repo and go to Changes

Expected behavior:
The icon does not overlap with the file name

Actual behavior:
The icon overlaps with the file name

[StanleyGoldman]

Is it the case that png and tiff files always have a missing icon?

[meaghanlewis]

@StanleyGoldman no it doesn't seem to be the case. I just imported some Assets from the Asset Store in Unity and saw they looked as expected when icons are present:

Im thinking this is less about images and more about files without icons.

[ThomasAunvik]

The reason the text "overlaps" the icon, cause there is no icon existing.

At Styles.cs Line 793 the EditorGUIUtility.FindTexture("DefaultAsset Icon") returns null.

I have tried overriding every other icon, and it seems that is the issue.

Not sure what other icons non-meta files use. Here is the result when overriding every icon with DefaultAssetIcon:

EDIT:
AssetDatabase.GetCachedIcon is what the assets are using, since meta files are not visible in the editor thats why meta files does not have a chached icon.