This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Downloader hangs when executed with no items #877
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be related to: #841
Depends on:
Testing local builds, where the conditions for downloading resources are slightly different.
I found an issue where the
Downloader
will hang whenRunSynchronously
is called with no items in the queue.Unity/src/GitHub.Api/Installer/GitInstaller.cs
Lines 260 to 264 in 675714a
It hangs because
TrySetResult
/TrySetException
is never called.