Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Dealing with metafiles that show changes on build #881

Merged
merged 3 commits into from
Aug 2, 2018

Conversation

StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Aug 1, 2018

Everytime I build these two files show up with just whitespace changes.

  • Removing files from destination
  • Updating .gitignore

@shana
Copy link
Member

shana commented Aug 1, 2018

This is weird, these files get copied from lib/sfw/mac/libsfw.bundle.meta and lib/sfw/linux/libsfw.so.meta during the build. The version that's committed in the Package directory is exactly the same as the one in the lib directory (we probably shouldn't have two copies of them, but oh well), why do you have modified files?

@shana
Copy link
Member

shana commented Aug 1, 2018

I'd rather update the .gitignore on the Package folder to ignore the files that are getting copied from lib (the Assets/Plugins/GitHub/Editor/x64/ and Assets/Plugins/GitHub/Editor/x86/ are already ignored, the others that are copied from lib should also have been ignored), these files should never change.

@StanleyGoldman StanleyGoldman force-pushed the fixes/meta-file-spaces branch from c9bb8a8 to f42dfc0 Compare August 1, 2018 18:53
@StanleyGoldman StanleyGoldman changed the title Updating meta files to include whitespace Dealing with metafiles that show changes on build Aug 2, 2018
@StanleyGoldman StanleyGoldman requested a review from shana August 2, 2018 12:43
@StanleyGoldman
Copy link
Contributor Author

StanleyGoldman commented Aug 2, 2018

This mistake stems from: 6cc72b7

@shana shana merged commit 5a4de2d into master Aug 2, 2018
@shana shana deleted the fixes/meta-file-spaces branch August 2, 2018 13:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants